Add option to choose which YouTube embed player to use for playback#802
Open
philklc wants to merge 1 commit intoHolodexNet:devfrom
Open
Add option to choose which YouTube embed player to use for playback#802philklc wants to merge 1 commit intoHolodexNet:devfrom
philklc wants to merge 1 commit intoHolodexNet:devfrom
Conversation
sphinxrave
reviewed
Dec 30, 2024
| prepend-icon=" " | ||
| class="mt-n4" | ||
| :items="[ | ||
| { text: $t('views.settings.YTEmbedVariant[0]'), value: '' }, |
Collaborator
There was a problem hiding this comment.
change this to ask as value probably
| const host = ( | ||
| this.$store.state.settings.YTEmbedVariant === "youtube" | ||
| // eslint-disable-next-line no-alert | ||
| || (this.$store.state.settings.YTEmbedVariant === "" && window.confirm(this.$t("views.settings.YTEmbedVariantPromptMsg"))) |
Collaborator
There was a problem hiding this comment.
only legal because vue mounts once
Contributor
There was a problem hiding this comment.
Note that browsing to a multiview page can trigger this confirmation pop-up once per video, and there's no way to tell what video each pop-up is for.
This is especially weird if you already have multiview state and then click a multiview link as you get confirmation for all the videos from the state, then asked if you want to replace the layout, and then confirmation for all the replacement videos.
It would IMO be better to display this as an in-page DOM question. Although that could be done as a follow-up potentially.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #801