Channel/watch pages have search bar to include channel by default - #806
Open
lbmaian wants to merge 4 commits into
Open
Channel/watch pages have search bar to include channel by default#806lbmaian wants to merge 4 commits into
lbmaian wants to merge 4 commits into
Conversation
lbmaian
force-pushed
the
channeldefaultsearch
branch
from
March 28, 2025 01:23
bd11567 to
b2ee12e
Compare
Contributor
Author
|
Anything blocking this from being accepted? |
Also made a bit more robust and efficient
lbmaian
force-pushed
the
channeldefaultsearch
branch
from
May 24, 2026 15:15
b2ee12e to
749f80b
Compare
lbmaian
changed the title
lbmaian
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When searching for only a channel (from the search bar), it goes to the channel page. However this removes the channel from the search bar, which is inconvenient when doing subsequent searches within a channel from that page.
It would also be convenient for watch pages to populate the channel in the search bar.
This PR addresses that by adding a "default" channel item to the search bar on channel/watch pages. This item is removed when going to a non-channel/watch/search page, or replaced if going to another channel/watch page.