feat(channel-socials): add bluesky link#833
Open
PetterSa wants to merge 2 commits intoHolodexNet:devfrom
Open
Conversation
Several vtubers, like Nimi Nightmare, uses bluesky actively, and I don't have to log in to see the latest posts, so I prefer to use that if I can. It is a pretty small change, I think I have implemented it similarly enough to existing code. Although I am not sure I understand what the hide parameters do, they look sort of unused? Regarding the SVG path, I took it directly from the bluesky page, imported it into this little tool https://aydos.com/svgedit/ , scaled it down to MDI size, added the correct amount of buffer and centered it. It should look correct, I can add a few screenshots in my PR :)
Several places misuses the ChannelSocials for the block and fav functionality in it. IMO they should be split. Anyway, for now I just correctly hide them where they should not be. For the hover effect on the channel chips visible in collabs, we show only fav. For the report button we show only block. It looks like WatchMentions is currently unused, but I updated it as well.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several vtubers, like Nimi Nightmare, uses bluesky actively, and I don't have to log in to see the latest posts, so I prefer to use that if I can.
It is a pretty small change, I think I have implemented it similarly enough to existing code.
Regarding the SVG path, I took it directly from the bluesky page, imported it into this little tool https://aydos.com/svgedit/ , scaled it down to MDI size, added the correct amount of buffer and centered it. It should look correct: here are a few screenshots:
Note: for this screenshot I enabled bluesky icon for everyone, it is not like that in the PR :)
