Skip to content

Improve bookmarklet to handle /shorts/ and /live/ and avoid navigating to null url #836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
FlaminSarge wants to merge 2 commits into
base: dev
Choose a base branch
from
+13 −4
Open

Improve bookmarklet to handle /shorts/ and /live/ and avoid navigating to null url #836

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3c6d206
Improve bookmarklet to handle /shorts/ and /live/ and avoid navigatin…
FlaminSarge Mar 19, 2026
97de07f
Fix lint issues (unrelated to PR)
FlaminSarge Mar 20, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion src/plugins/vuetify.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,16 @@ export const langs = [
{ val: "th", display: "ไทย", credit: "SnowNeko#0282" },
];

const possibleChars = [768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782, 783, 784, 785, 786, 787, 788, 789, 794, 795, 829, 830, 831, 832, 833, 834, 835, 836, 838, 842, 843, 844, 848, 849, 850, 855, 856, 859, 861, 862, 864, 865, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 820, 821, 822, 823, 824, 790, 791, 792, 793, 796, 797, 798, 799, 800, 801, 802, 803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817, 818, 819, 825, 826, 827, 828, 837, 839, 840, 841, 845, 846, 851, 852, 853, 854, 857, 858, 860, 863, 866];
const possibleChars = [
768, 769, 770, 771, 772, 773, 774, 775, 776, 777, 778, 779, 780, 781, 782,
783, 784, 785, 786, 787, 788, 789, 794, 795, 829, 830, 831, 832, 833, 834,
835, 836, 838, 842, 843, 844, 848, 849, 850, 855, 856, 859, 861, 862, 864,
865, 867, 868, 869, 870, 871, 872, 873, 874, 875, 876, 877, 878, 879, 820,
821, 822, 823, 824, 790, 791, 792, 793, 796, 797, 798, 799, 800, 801, 802,
803, 804, 805, 806, 807, 808, 809, 810, 811, 812, 813, 814, 815, 816, 817,
818, 819, 825, 826, 827, 828, 837, 839, 840, 841, 845, 846, 851, 852, 853,
854, 857, 858, 860, 863, 866,
];
const randInt = (upperBound) => Math.floor(Math.random() * upperBound);

function combiningChars() {
Expand Down
2 changes: 1 addition & 1 deletion src/utils/consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ export const langConversion = Object.freeze({
"lol-UWU": "en",
zh: "zh-Hant",
"zh-CN": "zh-Hans",
"en-GB": "enm"
"en-GB": "enm",
});

export const companionExtensionId = "jkdnofimdhpbhdjbcdlgnccfjjkidlgp";
Expand Down
4 changes: 2 additions & 2 deletions src/views/About.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -439,13 +439,13 @@
<div class="d-flex flex-column" style="margin-left: 0px">
<v-btn
class="text-left mt-4 white--text grey"
href="javascript:(function(){var v=new%20URLSearchParams(window.location.search).get('v');v&&(window.location.href='https://holodex.net/watch/'+v)})()"
href="javascript:!function(){let t=new URL(window.location);if(t.hostname.includes('youtube')){let a=t.searchParams.get('v')||(t.pathname.includes('/shorts/')?t.pathname.replace('/shorts/',''):t.pathname.includes('/live/')?t.pathname.replace('/live/',''):null);if(!a)return;t.searchParams.delete('v');window.location='https://holodex.net/watch/'+a+'?'+t.searchParams.toString()}}();"
>
Open in Holodex
</v-btn>
<v-btn
class="text-left mt-4 white--text grey"
href="javascript:(function(){var v=new%20URLSearchParams(window.location.search).get('v');v&&(window.location.href='https://staging.holodex.net/watch/'+v)})()"
href="javascript:!function(){let t=new URL(window.location);if(t.hostname.includes('youtube')){let a=t.searchParams.get('v')||(t.pathname.includes('/shorts/')?t.pathname.replace('/shorts/',''):t.pathname.includes('/live/')?t.pathname.replace('/live/',''):null);if(!a)return;t.searchParams.delete('v');window.location='https://staging.holodex.net/watch/'+a+'?'+t.searchParams.toString()}}();"
>
Open in Holodex Beta
</v-btn>
Expand Down
Loading