Video card menu fixes (primarily for editors) - #840
Open
lbmaian wants to merge 10 commits into
Open
Conversation
…ed quick editor dropdowns Specifically, it should only affect one of them and the quick editor dropdown takes precedence
(also some formatting changes from precommit lint)
Relies on waiting until menu's transitionend event
… the transition (including repositioning) instantaneous Old fix using transitionend event was too slow due to the relatively slow transition
The previous fix tried waiting for quick editor's mentions/topic to load, but it wasn't reliable, so this abandons that, and instead just ensures the quick editor's not lazily-loaded, which for videos without mentions works perfectly without needing any repositioning
… chip This makes quick editor (and video card menu) with 0 channel mentions have same height as one with a single row's worth of channel mentions, which also helps with first video card menu opening position Also ensures that the channel mention and topic inputs remain horizontally aligned
lbmaian
force-pushed
the
videocardmenufixes
branch
from
May 30, 2026 11:49
bf4c480 to
c5ece2e
Compare
Contributor
Author
|
Note on merging with #839: That PR also touches WatchQuickEditor, in particular adding |
…g wrong dimensions during loading
(should make merges easier)
… channel chip" This reverts commit c5ece2e.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change height of channel mention and topic buttons to be the same as the channel icons themselves, such that videos with 0 mentions have the same height as those with at most a single row's worth of mentions, and channel mention and topic inputs remain horizontally aligned. This helps with (3).edit: removed since conflicts with another PR that does it betterThere are some other changes that don't really change functionality - they're artifacts of the git precommit linter or leftover from previous fix attempts that made sense to keep (like moving tags/attrs around to avoid nested
<a>elements).