Skip to content

Video card menu fixes (primarily for editors) - #840

Open
lbmaian wants to merge 10 commits into
HolodexNet:devfrom
lbmaian:videocardmenufixes
Open

Video card menu fixes (primarily for editors)#840
lbmaian wants to merge 10 commits into
HolodexNet:devfrom
lbmaian:videocardmenufixes

Conversation

@lbmaian

@lbmaian lbmaian commented May 27, 2026

Copy link
Copy Markdown
Contributor
  1. Fix simultaneous arrow key navigation on video card menu and the nested channel mentions and topic dropdowns for editors. Practically this allows just using the keyboard to add channel mentions or select topic in that menu.
  2. Fix video card menu keyboard navigation breaking when menu items or another video card are hovered, page is scrolled, page loses focus, and possibly other cases.
  3. Fix for the first opening of the video card menu sometimes being mispositioned for editors (subsequent openings try to put menu to left of button yet still within viewport). This still doesn't fully fix the menu for videos that already have enough channel mentions (which are asynchronously loaded in) to affect the menu size, but it's good enough.
  4. Change height of channel mention and topic buttons to be the same as the channel icons themselves, such that videos with 0 mentions have the same height as those with at most a single row's worth of mentions, and channel mention and topic inputs remain horizontally aligned. This helps with (3). edit: removed since conflicts with another PR that does it better
  5. Fix error on channels page that resulted in video cards briefly having wrong dimensions during loading

There are some other changes that don't really change functionality - they're artifacts of the git precommit linter or leftover from previous fix attempts that made sense to keep (like moving tags/attrs around to avoid nested <a> elements).

lbmaian added 7 commits May 30, 2026 04:39
…ed quick editor dropdowns

Specifically, it should only affect one of them and the quick editor dropdown takes precedence
(also some formatting changes from precommit lint)
Relies on waiting until menu's transitionend event
… the transition (including repositioning) instantaneous

Old fix using transitionend event was too slow due to the relatively slow transition
The previous fix tried waiting for quick editor's mentions/topic to load, but it wasn't reliable, so this abandons that, and instead just ensures the quick editor's not lazily-loaded, which for videos without mentions works perfectly without needing any repositioning
… chip

This makes quick editor (and video card menu) with 0 channel mentions have same height as one with a single row's worth of channel mentions, which also helps with first video card menu opening position
Also ensures that the channel mention and topic inputs remain horizontally aligned
@lbmaian
lbmaian force-pushed the videocardmenufixes branch from bf4c480 to c5ece2e Compare May 30, 2026 11:49
@lbmaian

lbmaian commented Jun 2, 2026

Copy link
Copy Markdown
Contributor Author

Note on merging with #839: That PR also touches WatchQuickEditor, in particular adding @keydown.enter to the topic autocomplete. The @keydown.stop added to both the channel mentions and topic autocompletes in this PR's first commit are still required, so the topic autocomplete should have both @keydown.enter and @keydown.stop (and not naively merged into @keydown.enter.stop).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant