Skip to content

Add python wheel build pipeline (#123) - #131

Merged
Asd-g merged 3 commits into
masterfrom
building_wheels
Jul 7, 2026
Merged

Add python wheel build pipeline (#123)#131
Asd-g merged 3 commits into
masterfrom
building_wheels

Conversation

@Asd-g

@Asd-g Asd-g commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

This adds a script for building Python wheels.

In order for them to be published, a registration on PyPI should be done. @msg7086, as owner of this repo, I think it's better that you do the registration.

The package name is vapoursynth-lsmashsource.

As @Vodes said, he already published vapoursynth-lsmas.

Wheels and artifacts for testing.

@Vodes

Vodes commented Jun 28, 2026

Copy link
Copy Markdown

I'd argue just naming the package vapoursynth-<namespace> is more intuitive and most plugins from what I know also just do that (see https://pypi.org/search/?q=vapoursynth). As I mentioned before I can simply hand over that entire project (add another user or however many as owner and either remove myself or either one of you removes me).

@Asd-g

Asd-g commented Jun 28, 2026

Copy link
Copy Markdown
Contributor Author

Ok. I don't mind the name vapoursynth-lsmas.
I also don't mind if you continue managing the PyPI site if you want.
You could add msg7086 as an owner for backup access, if he doesn't mind it.

@msg7086

msg7086 commented Jun 29, 2026

Copy link
Copy Markdown
Member

I think we 3 can all have equal access.

I don't intend to keep the project personal and maintain control. Anyone who's interested in helping maintaining the project can keep/take access and contribute.

@Vodes

Vodes commented Jun 29, 2026

Copy link
Copy Markdown

Ok. I don't mind the name vapoursynth-lsmas. I also don't mind if you continue managing the PyPI site if you want. You could add msg7086 as an owner for backup access, if he doesn't mind it.

User doesn't exist as of now.
Anyways there isn't much to manage. The upload process takes the readme you put into the toml and all other metadata is taken from there too.


As for testing the builds.

Linux x86 seems to work fine. Don't have an arm machine there.

macos arm64 is broken; It won't even attempt to load that since it's somehow an so for the main plugin and (presumably) lacking a lot of the necessary libraries in the dylibs folder.

Also don't think you're supposed to dump that bin and all those other files into the plugins folder (this happens on linux too):

Image of the wheel layout differences

@msg7086

msg7086 commented Jun 30, 2026

Copy link
Copy Markdown
Member

Sorry I was travelling. I just created the account. Thanks.

Remove the unnecessary files.

Add VapourSynth autoload test.
@Asd-g

Asd-g commented Jul 2, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for testing. Can you test with the latest changes?

@Vodes

Vodes commented Jul 4, 2026

Copy link
Copy Markdown

Sorry had a bit of a busy week.
Can confirm both the linux x64 on my main machine and the macos arm (using an M1 Mac mini) builds work fine.

@Asd-g

Asd-g commented Jul 4, 2026

Copy link
Copy Markdown
Contributor Author

Thanks for testing.

Now only the publishing details remain.

@Vodes

Vodes commented Jul 5, 2026

Copy link
Copy Markdown

I added this repo to the trusted publishers on pypi. Minor caveat being that it has to be a specific workflow file. Would have to be publish-pypi.yml for that workflow. I can change that if you want a different name though.

I would recommend only running that on tags and maybe skipping .dev versions but that's just what I did according to my tastes.
See https://github.com/Vodes/L-SMASH-Works/blob/master/.github/workflows/ci-all.yml#L49-L95

If you want to publish wheels for the current version I'd recommend making a 1292.post1 tag or something like it.
https://packaging.python.org/en/latest/specifications/version-specifiers/#public-version-identifiers
https://packaging.python.org/en/latest/specifications/version-specifiers/#post-releases

... Actually I just noticed you didn't make a tag/release for 1292 yet at all so feel free to ignore that lol

Add publishing on tag push.
@Asd-g
Asd-g merged commit 1782076 into master Jul 7, 2026
16 checks passed
@Asd-g
Asd-g deleted the building_wheels branch July 7, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants