Skip to content

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Aug 11, 2025

GitHub Actions now supports Node 24. Node 24 supports natively running TypeScript without needing a compile stage (erasable syntax only) which means we can adopt it without needing to add any build stages.

This pull request experiments with adopting TypeScript (for one action in this initial draft).

Given the Actions runner with support for Node 24 is just 2 weeks old, perhaps we want to allow a little more time before doing this since we don't do tagged releases?

package.json Outdated
"devDependencies": {
"@tsconfig/node-ts": "^23.6.1",
"@tsconfig/node24": "^24.0.1",
"@types/node": "^24.2.1",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want Dependabot to bump the major version here so may need to figure out how best to do that.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea! ✅ when 🟢

Copy link

github-actions bot commented Sep 3, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Sep 3, 2025
@Bo98 Bo98 removed the Stale label Sep 3, 2025
@Bo98
Copy link
Member Author

Bo98 commented Sep 11, 2025

Code wise this is ready but need to:

  • Update dependabot config as per above
  • Fix coverage regressions
  • Test setup-homebrew still works on Portable Ruby runners (as it's technically under Node 24 requirements)

This did catch one edge case bug in check-commit-format (we just probably never hit that edge case) so typing has at least proven some use.

Copy link

github-actions bot commented Oct 3, 2025

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.

@github-actions github-actions bot added the Stale label Oct 3, 2025
@Bo98 Bo98 removed the Stale label Oct 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants