-
-
Notifications
You must be signed in to change notification settings - Fork 46
Adopt TypeScript under Node 24 #734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
package.json
Outdated
"devDependencies": { | ||
"@tsconfig/node-ts": "^23.6.1", | ||
"@tsconfig/node24": "^24.0.1", | ||
"@types/node": "^24.2.1", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We don't want Dependabot to bump the major version here so may need to figure out how best to do that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! ✅ when 🟢
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Code wise this is ready but need to:
This did catch one edge case bug in |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
GitHub Actions now supports Node 24. Node 24 supports natively running TypeScript without needing a compile stage (erasable syntax only) which means we can adopt it without needing to add any build stages.
This pull request experiments with adopting TypeScript (for one action in this initial draft).
Given the Actions runner with support for Node 24 is just 2 weeks old, perhaps we want to allow a little more time before doing this since we don't do tagged releases?