Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Homebrew 4.2.0 #1002

Merged
merged 1 commit into from
Dec 18, 2023
Merged

Homebrew 4.2.0 #1002

merged 1 commit into from
Dec 18, 2023

Conversation

MikeMcQuaid
Copy link
Member

Release notes blog post for Homebrew 4.2.0.

Note: make sure the mailing list is fixed before this gets sent out.

SMillerDev
SMillerDev previously approved these changes Dec 14, 2023
_posts/2023-12-18-homebrew-4.2.0.md Outdated Show resolved Hide resolved
_posts/2023-12-18-homebrew-4.2.0.md Outdated Show resolved Hide resolved
_posts/2023-12-18-homebrew-4.2.0.md Outdated Show resolved Hide resolved
_posts/2023-12-18-homebrew-4.2.0.md Outdated Show resolved Hide resolved
@MikeMcQuaid MikeMcQuaid changed the title Homebrew 4.2.0 [WIP] Homebrew 4.2.0 Dec 15, 2023
@MikeMcQuaid MikeMcQuaid force-pushed the 4.2.0 branch 2 times, most recently from 42cd8c6 to e71d293 Compare December 18, 2023 17:17
Release notes blog post for Homebrew 4.2.0.

Note: make sure the mailing list is fixed before this gets sent out.
@MikeMcQuaid MikeMcQuaid changed the title [WIP] Homebrew 4.2.0 Homebrew 4.2.0 Dec 18, 2023
@MikeMcQuaid MikeMcQuaid marked this pull request as ready for review December 18, 2023 17:17
[Portable Ruby 3.1.4](https://github.com/Homebrew/brew/pull/16145) that will be installed whenever needed on
Linux x86_64 and macOS Apple Silicon and Intel.
This marks the end of Homebrew using the macOS system Ruby.
Pour one out for our old friend `/usr/bin/ruby` on macOS 🍻.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RIP 🍻 🚀

@MikeMcQuaid MikeMcQuaid merged commit db3d893 into master Dec 18, 2023
3 checks passed
@MikeMcQuaid MikeMcQuaid deleted the 4.2.0 branch December 18, 2023 17:26
- [Homebrew can be configured with `.env` files.](https://github.com/Homebrew/brew/pull/15787)
- [Homebrew supports macOS Sonoma.](https://github.com/Homebrew/brew/pull/16019)
- [`OS::Mac` and `MacOS` usage in formulae on Linux is deprecated.](https://github.com/Homebrew/brew/pull/16224)
Please guard all uses in formulae with `if OS.mac?` or `if OS.linux?` as appropriate.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question: I'm a few minutes late on this, but are these preferred over on_macos and on_linux and friends? We're using those inside some internal formulae.

Copy link
Member

@Bo98 Bo98 Dec 18, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Depends. Basic reading of the formulae (i.e. outside def install/test) should, where possible, use on_{system} so that you can, e.g., know the dependencies on Linux from a macOS system.

Inside of def install only ever runs on the system you are installing on so use if OS.whatever? there.

I believe brew style checks for the latter case, but does not check for the former case in third-party taps since it doesn't support 100% of use cases. https://github.com/Homebrew/brew/blob/master/Library/Homebrew/rubocops/lines.rb#L403-L442

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants