Remove fish command completions for excluded commands #18793
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaminthorns
force-pushed
the
remove-instal-alias-fish-completions
branch
from
7512f9d to
feeb95e
Compare
jaminthorns
changed the title
*instal aliases
reitermarkus
approved these changes
Nov 20, 2024
This removes fish command completions (but keeps argument completions) for commands in the `COMPLETIONS_EXCLUSION_LIST` list. It also removes unnecessary exclusions of `*instal` aliases in command suggestions in bash and fish completions, since those were removed from `internal_commands_list.txt` in #10229. This makes `COMPLETIONS_EXCLUSION_LIST` the single source of truth for commands to exclude from completions.
jaminthorns
force-pushed
the
remove-instal-alias-fish-completions
branch
from
f4c95a5 to
c5253b2
Compare
MikeMcQuaid
approved these changes
Nov 21, 2024
There was a problem hiding this comment.
Great work @jaminthorns, particularly on your first PR! Appreciated your ability to go from failing CI to a perfect solution here. You rock!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?This removes fish command completions (but keeps argument completions) for commands in the
COMPLETIONS_EXCLUSION_LISTlist.It also removes unnecessary exclusions of
*instalaliases in command suggestions in bash and fish completions, since those were removed frominternal_commands_list.txtin #10229. This makesCOMPLETIONS_EXCLUSION_LISTthe single source of truth for commands to exclude from completions.