Bump some utils/ files to Sorbet typed: strict#19094
Merged
Conversation
MikeMcQuaid
approved these changes
Jan 15, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Good to go whenever you are! All comments are non-blocking, we can always clean this up post merge.
6b544d8 to
d2fd233
Compare
MikeMcQuaid
approved these changes
Jan 22, 2025
Member
MikeMcQuaid
left a comment
There was a problem hiding this comment.
Looks good, thanks! All comments are non-blocking, feel free to disagree and self-merge with or without accepting without a rereview.
Co-authored-by: Mike McQuaid <mike@mikemcquaid.com>
d2fd233 to
66e5084
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?typed: strictin all (non-package) files in Homebrew organisation #17297.