[WIP] bump: bump synced formula together

[bevanjkay]

• Have you followed the guidelines in our Contributing document?
• Have you checked to ensure there aren't other open Pull Requests for the same change?
• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your changes? Here's an example.
• Have you successfully run brew style with your changes locally?
• Have you successfully run brew typecheck with your changes locally?
• Have you successfully run brew tests with your changes locally?

---

TODO:

• Add tests
• Update brew bump-cask-pr

[nandahkrishna]

Thanks @bevanjkay, I think the overall logic looks good here – it's just that the diff is a bit scary because everything's been moved into a loop over the list of formulae to bump together (and pr_info contains multiple commits, and only after all these commits are created should the audit checks be run).

Once you get the time to add tests I'd be happy to review this in more detail and even test it out.

[nandahkrishna]

I think we should just have a flag like --bump-synced, which bumps synced formulae based on the list/JSON file in homebrew-core, rather than having to pass the list of synced formulae here.

[nandahkrishna]

Suggested change

	# return if duplicate_pull_requests.present?
	return if duplicate_pull_requests.present?

I think we discussed this at the end of the AGM, but this is just a reminder 😆.

[nandahkrishna]

Suggested change

	# run_audit(formula, alias_rename, old_contents)
	run_audit(formula, alias_rename, old_contents)

Again, just a reminder – and for context to others looking at this PR, these lines have been commented out just to make testing easy.

[nandahkrishna]

Potentially another reminder to uncomment.

[bevanjkay]

I think that ideally I will extract the loop logic into a separate function to make it a bit clearer.
This one has been difficult to test because it's not often that an opportunity arises to bump synced formula - but when I have some time I will try to replicate this in a test tap.

I have ran some singular bumps with this branch checked out, and there is currently an issue where the PR title is incorrect.

Looking to get back to this PR in the next week or two.