Install size #19254
Install size #19254
Conversation
… and adding parameter
|
Adding the |
There was a problem hiding this comment.
Looking good so far, thanks @tyuwags! Remaining bits would be:
- extracting into shared methods
- adding a unit test for the extracted method to get some code coverage for this
Shout if you need help with any of that!
| @@ -302,6 +307,98 @@ def run | |||
| Install.perform_preinstall_checks_once | |||
| Install.check_cc_argv(args.cc) | |||
|
|
|||
| ask_input = lambda { | |||
There was a problem hiding this comment.
Can these be dedicated methods rather than a lambda? The method this is part of is getting very long and we don't typically use lambda like this just for variable scoping.
| @@ -126,6 +131,98 @@ def run | |||
| unless formulae.empty? | |||
| Install.perform_preinstall_checks_once | |||
|
|
|||
| ask_input = lambda { | |||
| ohai "Do you want to proceed with the installation? [Y/y/yes/N/n]" | |||
There was a problem hiding this comment.
Seems like a lot of duplicated code here, would be good to extract into shared method(s) in Library/Homebrew/install.rb
|
For the shared library: |
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?resolve #18373
As discussed in the issue, these changes add the
--askoption and theHOMEBREW_ASKenvironment variable to display the packages and dependencies that will be installed, along with their sizes, and prompt the user for input.