Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dockerfile: remove sudo #19311

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Dockerfile: remove sudo #19311

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

Homebrew on Linux is designed to be able to run without sudo. We
should leave it out of our Docker containers to make sure we're not
relying on it anywhere.

Homebrew on Linux is designed to be able to run without `sudo`. We
should leave it out of our Docker containers to make sure we're not
relying on it anywhere.
@Bo98
Copy link
Member

Bo98 commented Feb 15, 2025

This is a good idea for Homebrew/core PRs but it will break things: https://github.com/Homebrew/actions/blob/5fa6b2b81cecc8034b08c5e05285c9d1ec728e9a/setup-homebrew/main.sh#L78, https://github.com/Homebrew/homebrew-core/blob/34b615381d397dd75abe2861db66d1f970a99c9f/.github/workflows/publish-commit-bottles.yml#L337. Plus various third-party use cases we have no control over.

Maybe some magic in Homebrew/actions/pre-build to neuter sudo might be an alternative solution.

@MikeMcQuaid
Copy link
Member

👍🏻 from me when it's working as expected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants