Add `brew bundle exec --services` #19552

Bo98 · 2025-03-20T07:17:19Z

A nice shortcut to quickly start and stop all formulae with services in your Brewfile. This makes it nicer if you have e.g. differing database versions (which often still share the same port) between projects.

MikeMcQuaid

Thanks, looks good so far! What happens if there's an existing service already running, will this automatically stop it? If not: that seems desirable.

Library/Homebrew/bundle/commands/services.rb

Library/Homebrew/bundle/services.rb

Library/Homebrew/services/commands/info.rb

Bo98 · 2025-03-21T04:00:17Z

What happens if there's an existing service already running, will this automatically stop it?

Not currently. brew services does not support temporarily stopping a service well at the moment (there's kill but the service can just auto-restart). I want to avoid removing the LaunchAgents service.

Not sure how such CLI should look. brew services stop --keep?

MikeMcQuaid · 2025-03-21T09:29:47Z

Not currently. brew services does not support temporarily stopping a service well at the moment (there's kill but the service can just auto-restart). I want to avoid removing the LaunchAgents service.

Not sure how such CLI should look. brew services stop --keep?

Don't feel strongly about the API. I agree with not removing the service if possible but, if it's not, it feels more sensible to remove it.

I think for run to be useful in this context, it needs to be able to also stop. If one project is running postgresql@14 and another postgresql@15 on the same ports, you need to be able to provide a way to ensure that brew bundle services can not only start postgresql@15 but also stop postgresql@14 if needed. We already have some context for this with the conflicts_with: ["mysql"] brew bundle DSL; this feels like another good use of that.

Bo98 · 2025-03-25T03:44:45Z

Rebased on #19579 to avoid conflicts.

MikeMcQuaid

Thanks @Bo98! Not sure exactly how but it feels like the e.g. service_change_state! logic in bundle/brew_installer.rb and/or bundle/brew_services.rb should be integrated here. Not sure I understand why/when you'd use bundle/brew_services.rb vs. bundle/services?

The base branch was changed.

Bo98 · 2025-03-27T06:15:05Z

it feels like the e.g. service_change_state! logic in bundle/brew_installer.rb

It intentionally behaves a little differently but indeed this should at least be following the versioned env path so I've made it now do so.

bundle/brew_services.rb should be integrated here

I've done this now

Not sure I understand why/when you'd use bundle/brew_services.rb vs. bundle/services?

I've folded the latter into bundle/commands/services to avoid confusion.

MikeMcQuaid

Looking good! Might be nice to extract the brew bundle services commands into another PR; think they require a bit more thought/discussion and the rest seems almost ready to go.

Library/Homebrew/bundle/brew_services.rb

MikeMcQuaid

Thanks @Bo98, great work! Merging as-is but would love some of the missing test coverage to come in a follow-up PR.

MikeMcQuaid · 2025-03-28T08:41:49Z

Library/Homebrew/bundle/commands/exec.rb

+            exit_code = 0
+            run_services(@dsl.entries) do
+              Kernel.system(*args)
+              exit_code = $CHILD_STATUS.exitstatus


Would love a follow-up PR with some test coverage here.

MikeMcQuaid · 2025-03-28T08:41:54Z

Library/Homebrew/bundle/commands/exec.rb

+          ).void
+        }
+        private_class_method def self.map_service_info(entries, &_block)
+          entries_formulae = entries.filter_map do |entry|


Would love a follow-up PR with some test coverage here.

MikeMcQuaid · 2025-03-28T08:42:04Z

Library/Homebrew/bundle/commands/exec.rb

+
+        sig { params(entries: T::Array[Homebrew::Bundle::Dsl::Entry], _block: T.nilable(T.proc.void)).void }
+        private_class_method def self.run_services(entries, &_block)
+          services_to_restart = []


Would love a follow-up PR with some test coverage here.

MikeMcQuaid · 2025-03-28T08:42:12Z

Library/Homebrew/bundle/commands/exec.rb

+
+        sig { params(entries: T::Array[Homebrew::Bundle::Dsl::Entry]).void }
+        private_class_method def self.stop_services(entries)
+          map_service_info(entries) do |info, _, _|


Would love a follow-up PR with some test coverage here.

Bo98 force-pushed the bundle-services branch from 4b126ef to a4a04de Compare March 20, 2025 07:41

carlocab approved these changes Mar 20, 2025

View reviewed changes

MikeMcQuaid previously approved these changes Mar 20, 2025

View reviewed changes

Bo98 force-pushed the bundle-services branch 2 times, most recently from d300326 to 486ec7d Compare March 21, 2025 07:24

Bo98 force-pushed the bundle-services branch from 486ec7d to 81856ea Compare March 25, 2025 03:44

Bo98 changed the base branch from master to bundle_version_file March 25, 2025 03:44

carlocab previously approved these changes Mar 25, 2025

View reviewed changes

Bo98 force-pushed the bundle-services branch from 81856ea to 0492fa1 Compare March 25, 2025 03:55

MikeMcQuaid reviewed Mar 25, 2025

View reviewed changes

Base automatically changed from bundle_version_file to master March 25, 2025 10:25

Bo98 force-pushed the bundle-services branch from 0492fa1 to a6f9f6c Compare March 27, 2025 06:12

Bo98 force-pushed the bundle-services branch 2 times, most recently from 1f5e3d9 to f0f9bcf Compare March 27, 2025 06:31

MikeMcQuaid reviewed Mar 27, 2025

View reviewed changes

Library/Homebrew/bundle/brew_services.rb Outdated Show resolved Hide resolved

p-linnane approved these changes Mar 27, 2025

View reviewed changes

Bo98 added 7 commits March 28, 2025 05:21

services: add --keep flag

0b58e8f

Add brew bundle services helper

615fb76

services: support --file= in restart command

2b906e4

bundle: use version env for installer service handling

786ad34

bundle: add --services flag for sh and exec

c7e8b66

Fold brew bundle services into exec

650f62b

test/bundle: improve coverage

c273d8b

Bo98 force-pushed the bundle-services branch from f0f9bcf to c273d8b Compare March 28, 2025 05:55

carlocab approved these changes Mar 28, 2025

View reviewed changes

Bo98 changed the title ~~Add brew bundle services helper~~ Add brew bundle exec --services Mar 28, 2025

MikeMcQuaid approved these changes Mar 28, 2025

View reviewed changes

MikeMcQuaid added this pull request to the merge queue Mar 28, 2025

Merged via the queue into master with commit 2603401 Mar 28, 2025
36 checks passed

MikeMcQuaid deleted the bundle-services branch March 28, 2025 09:04

Uh oh!

Add brew bundle exec --services #19552

Add brew bundle exec --services #19552

Uh oh!

Conversation

Bo98 commented Mar 20, 2025

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Bo98 commented Mar 21, 2025

Uh oh!

MikeMcQuaid commented Mar 21, 2025

Uh oh!

Bo98 commented Mar 25, 2025

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Bo98 commented Mar 27, 2025

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

MikeMcQuaid left a comment

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

MikeMcQuaid Mar 28, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Add `brew bundle exec --services` #19552

Add `brew bundle exec --services` #19552