Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shebangs: fix broken shebangs like #!python #19563

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

botantony
Copy link
Contributor

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

I tried to fix broken shebang for watchman formula (related issue: Homebrew/homebrew-core#210978) but rewrite_shebang didn't work. This patch allows to fix broken shebangs such as #!python, #!python3, etc.

@botantony
Copy link
Contributor Author

UPD: think it would be reasonable to made this change for the rest languages that support shebang rewriting

@botantony botantony changed the title python/shebang: fix broken shebangs like #!python shebangs: fix broken shebangs like #!python Mar 20, 2025
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks @botantony!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 21, 2025
Merged via the queue into Homebrew:master with commit 6f04ee4 Mar 21, 2025
36 checks passed
@botantony botantony deleted the python-shebang branch March 21, 2025 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants