Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bundle: remove include Kernel references #19566

Merged
merged 1 commit into from
Mar 21, 2025
Merged

bundle: remove include Kernel references #19566

merged 1 commit into from
Mar 21, 2025

Conversation

Bo98
Copy link
Member

@Bo98 Bo98 commented Mar 21, 2025 •
edited
Loading

Bring bundle up to the usual standards of the rest of the Homebrew/brew codebase

@Bo98 Bo98 force-pushed the bundle-no-kernel branch from 73ff9b4 to ba5bbde Compare March 21, 2025 04:27
carlocab
carlocab approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to fix up the various Kernel.system calls too?

@Bo98
Copy link
Member Author

Bo98 commented Mar 21, 2025

Might be good to fix up the various Kernel.system calls too?

Bundle.system exists. I assume it's to avoid that (for some reason).

Maybe worth phasing out Bundle.system for one of the countless Homebrew command execution methods. Will need to look into what the differences are more.

@Bo98 Bo98 force-pushed the bundle-no-kernel branch from ba5bbde to 7e64051 Compare March 21, 2025 04:43
MikeMcQuaid
MikeMcQuaid approved these changes Mar 21, 2025
View reviewed changes
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid MikeMcQuaid added this pull request to the merge queue Mar 21, 2025
Merged via the queue into master with commit 81bf90b Mar 21, 2025
36 checks passed
@MikeMcQuaid MikeMcQuaid deleted the bundle-no-kernel branch March 21, 2025 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MikeMcQuaid MikeMcQuaid MikeMcQuaid approved these changes

@carlocab carlocab carlocab approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bo98 @MikeMcQuaid @carlocab