Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bundle: require more lazily #19568

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

bundle: require more lazily #19568

wants to merge 1 commit into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew style with your changes locally?
  • Have you successfully run brew typecheck with your changes locally?
  • Have you successfully run brew tests with your changes locally?

This will hopefully make using brew bundle a little bit snappier.

Unfortunately this doesn't seem to make brew bundle check reliably faster yet, so I'm still looking for tweaks here that would improve this.

@carlocab carlocab self-assigned this Mar 21, 2025
This will hopefully make using `brew bundle` a little bit snappier.
@carlocab carlocab force-pushed the bundle-lazy-require branch from 3ab6c74 to bce5253 Compare March 21, 2025 08:38
Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @carlocab! Think it's worth merging as-is because the "require hygiene" here is much better.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants