-
-
Notifications
You must be signed in to change notification settings - Fork 10.3k
bundle/commands/exec: check that Brewfile
is installed with --check
#19637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CC @Homebrew/maintainers, @jacobbednarz, @colindean for thoughts on this vs #19636 |
40d385d
to
b1e4f09
Compare
4c9a304
to
e3ea5e9
Compare
@carlocab and I chatted privately about the performance differences and, given that #19636 is a fairly major performance regression: I'm 👍🏻 on this approach. Thanks for opening PRs to compare both, though ❤️ |
971440d
to
b68987e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making this easier to review! Would be great to have some more test coverage here but otherwise 🎉 ✅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM on a visual check. I'd prefer the behavior here to that in #19636.
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
`brew bundle exec` behaves correctly only after doing `brew bundle install`. Running `brew bundle check` can be slow, so let's add a `--check` flag to `brew bundle exec` which will also run `brew bundle check` before `brew bundle exec` to ensure that the `Brewfile` has been installed before proceeding.
b68987e
to
08d5ca0
Compare
brew style
with your changes locally?brew typecheck
with your changes locally?brew tests
with your changes locally?brew bundle exec
behaves correctly only after doingbrew bundle install
.Running
brew bundle check
can be slow, so let's add a--check
flagto
brew bundle exec
which will also runbrew bundle check
beforebrew bundle exec
to ensure that theBrewfile
has been installedbefore proceeding.
Alternative to #19636 which makes
--check
the default behaviour. I have a mildpreference for this version since the additional
brew bundle check
makesbrew bundle env
andbrew bundle exec true
60% slower.Another option is to merge #19636 while adding a
--no-check
flag for users whoalready know their
Brewfile
is installed and don't want to incur the overheadof
brew bundle check
.