-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
feat: Add AppImage support for Linux Casksfeat: add appimage support for linux #21225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
5370783 to
9d01204
Compare
9d01204 to
fa64172
Compare
|
If these are just my changes this will break cask CI because I had only half an attempt to make Linux only and partial arch requirement installs work. |
|
Hi! Thanks for the heads up. I've actually built upon your initial work and fixed the issues to get the CI passing. Specifically, I:
The CI checks are currently all green ✅. |
|
None of those are the issue. The issue is that since there are essentially no Appimages that support ARM, the cask CI needs to be able to support selective architecture selections. That part is currently not working, and needs more testing and coding. It should also probably be split out from this PR, since it's blocking a flutter PR in the cask repo. |
SMillerDev
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The problem isn't that appimages need special handling though. They problem is that if you define an architecture requirement in an on_linux block, the CI matrix builder does not honor it.
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. |
Description
This PR adds support for
appimageartifacts in Casks, primarily for Linux support.Changes
Cask::Artifact::AppImageclass.appimagedirconfiguration (defaults to~/Applications).appimagedir.dsl_keyto ensureappimagestanza works correctly.Testing
brew tests --only=cask/artifact/appimagepasses.- [ ] Have you followed the guidelines in our Contributing document?brew lgtm(style, typechecking and tests) with your changes locally?