cask/test: create cask installer stub #21441
Open
+48
−12
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This PR creates a new test method for using an installer stub for cask installs.
There are a number of tests that require an "installation" to exist but they don't actually make use of the installed files. The stub method creates a minimal installation that is detected for use in these instances.
The
cask/upgradetest suite time has been reduced by 55% according to my testing.Note: I use
claude-codeto help with the methodology for creating this new method. I had tried to optimise this test a few times unsuccessfully in the past, but this approach makes a lot of sense to me.