Skip to content

Conversation

@bevanjkay
Copy link
Member

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

This PR creates a new test method for using an installer stub for cask installs.
There are a number of tests that require an "installation" to exist but they don't actually make use of the installed files. The stub method creates a minimal installation that is detected for use in these instances.

The cask/upgrade test suite time has been reduced by 55% according to my testing.

Note: I use claude-code to help with the methodology for creating this new method. I had tried to optimise this test a few times unsuccessfully in the past, but this approach makes a lot of sense to me.

Copy link
Member

@MikeMcQuaid MikeMcQuaid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants