Serialize FormulaStructs in the internal API
#21456
Open
+299
−52
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a cleaner attempt of #21429.
I've added
serializeanddeserializemethods toFormulaStructto efficiently store formula data in JSON format. After the simplifications made in #21455, the code needed to accomplish this is pretty straightforward.The goal is that the only special handling needed in
FormulaStruct#serializeandFormulaStruct#deserializeis for cases where there is a simpler way to store the data than is needed byFormulary. At the moment, the only two customizations needed are:uses_from_macosinformation: deduplicate dependencies that are both stable and head deps by storing shared dependencies separatelyI also added a handful of methods to
Utilsso they can, eventually, be used byCaskStruct. I've added tests for all of these methods.