Xml: expand test coverage #21477
Open
Xml: expand test coverage #21477
+60
−39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull request overview
This PR expands test coverage for the livecheck Xml strategy to 100%, while also strengthening type safety by making the return type of parse_xml non-nullable.
Changes:
- Strengthened the return type signature of
Xml.parse_xmlfromT.nilable(REXML::Document)toREXML::Document - Removed unreachable guard in
versions_from_contentthat checked for blank XML - Added comprehensive test coverage for error handling edge cases in XML parsing
- Refactored test structure to use a more maintainable
match_datahash organization
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/livecheck/strategy/xml.rb | Updated return type signature for parse_xml to be non-nullable and removed unreachable blank check |
| Library/Homebrew/test/livecheck/strategy/xml_spec.rb | Added new error handling tests, refactored test data structure, and expanded coverage to 100% |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
samford
force-pushed
the
livecheck/xml-expand-test-coverage
branch
2 times, most recently
from
1b81af7 to
6ae96e9
Compare
This expands test coverage for livecheck's `Xml` strategy, bringing it to 100% coverage for lines and branches. To achieve this, it was necessary to strengthen the return type of `parse_xml` and remove a related guard in `versions_from_content` that can never be true. `parse_xml` should only ever return an `REXML::Document` or raise an error, so it can't return `nil`. The `Sparkle.items_from_content` method contains the same guard, so this removes it from there as well.
samford
force-pushed
the
livecheck/xml-expand-test-coverage
branch
from
6ae96e9 to
b48abf4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew lgtm(style, typechecking and tests) with your changes locally?This expands test coverage for livecheck's
Xmlstrategy, bringing it to 100% coverage for lines and branches.To achieve this, it was necessary to strengthen the return type of
parse_xmland remove a related guard inversions_from_contentthat can never be true.parse_xmlshould only ever return anREXML::Documentor raise an error, so it can't returnnil.Like #21476, this is part of some overarching work to ensure that all strategy
find_versionsmethods have acontentparameter (exceptExtractPlist) and to increase test coverage for all the strategies to 100%. Changing theparse_xmlreturn type felt a little out of scope, so I split this into a separate PR.