upgrade: add final summary#22140
Draft
MikeMcQuaid wants to merge 1 commit intomainfrom
Draft
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a “Final upgrade summary” to brew upgrade output to make end-of-run results easier to scan, while reusing information already gathered during the upgrade (rather than re-querying).
Changes:
- Track upgrade details (version changes, pinned, deprecated/disabled involvement, and formulae building from source) during formula/cask upgrade execution.
- Print a narrow “Final upgrade summary” at the end of
brew upgrade. - Add/extend unit test coverage for summary recording and output formatting.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/cmd/upgrade.rb |
Introduces FinalUpgradeSummary, records summary data during upgrades, and prints a final summary at the end of the command. |
Library/Homebrew/cask/upgrade.rb |
Adds optional “summary” accumulator arrays to collect cask upgrade/deprecation/disabled info during cask selection/upgrade. |
Library/Homebrew/test/cmd/upgrade_spec.rb |
Adds tests for final summary printing and for recording formula-related summary fields. |
Library/Homebrew/test/cask/upgrade_spec.rb |
Adds tests for recording cask-related summary fields (upgrades, deprecated, disabled). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
736fea2 to
fab5f33
Compare
- Make `brew upgrade` easier to scan after noisy output. - Preserve existing progress output while narrowing the final view. - Reuse selected formula and cask upgrade data instead of re-querying. - Keep final summary section headings terse and unindented.
fab5f33 to
b4e04c0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested in our user survey.
brew upgradeeasier to scan after noisy output.brew lgtm(style, typechecking and tests) with your changes locally?OpenAI Codex xhigh with manual review and testing.