Skip to content

upgrade: add final summary#22140

Draft
MikeMcQuaid wants to merge 1 commit intomainfrom
narrower-final-upgrade-summary-for-brew-upgrade
Draft

upgrade: add final summary#22140
MikeMcQuaid wants to merge 1 commit intomainfrom
narrower-final-upgrade-summary-for-brew-upgrade

Conversation

@MikeMcQuaid
Copy link
Copy Markdown
Member

@MikeMcQuaid MikeMcQuaid commented May 5, 2026

Requested in our user survey.

  • Make brew upgrade easier to scan after noisy output.
  • Preserve existing progress output while narrowing the final view.
  • Reuse selected formula and cask upgrade data instead of re-querying.

  • Have you followed the guidelines in our Contributing document?
  • Have you checked to ensure there aren't other open Pull Requests for the same change?
  • Have you added an explanation of what your changes do and why you'd like us to include them? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you written new tests (excluding integration tests) for your changes? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) with your changes locally?

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes. Non-maintainers may only have one AI-assisted/generated PR open at a time.

OpenAI Codex xhigh with manual review and testing.


Copilot AI review requested due to automatic review settings May 5, 2026 18:08
@MikeMcQuaid MikeMcQuaid marked this pull request as draft May 5, 2026 18:09
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a “Final upgrade summary” to brew upgrade output to make end-of-run results easier to scan, while reusing information already gathered during the upgrade (rather than re-querying).

Changes:

  • Track upgrade details (version changes, pinned, deprecated/disabled involvement, and formulae building from source) during formula/cask upgrade execution.
  • Print a narrow “Final upgrade summary” at the end of brew upgrade.
  • Add/extend unit test coverage for summary recording and output formatting.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
Library/Homebrew/cmd/upgrade.rb Introduces FinalUpgradeSummary, records summary data during upgrades, and prints a final summary at the end of the command.
Library/Homebrew/cask/upgrade.rb Adds optional “summary” accumulator arrays to collect cask upgrade/deprecation/disabled info during cask selection/upgrade.
Library/Homebrew/test/cmd/upgrade_spec.rb Adds tests for final summary printing and for recording formula-related summary fields.
Library/Homebrew/test/cask/upgrade_spec.rb Adds tests for recording cask-related summary fields (upgrades, deprecated, disabled).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@MikeMcQuaid MikeMcQuaid force-pushed the narrower-final-upgrade-summary-for-brew-upgrade branch from 736fea2 to fab5f33 Compare May 5, 2026 18:32
- Make `brew upgrade` easier to scan after noisy output.
- Preserve existing progress output while narrowing the final view.
- Reuse selected formula and cask upgrade data instead of re-querying.
- Keep final summary section headings terse and unindented.
@MikeMcQuaid MikeMcQuaid force-pushed the narrower-final-upgrade-summary-for-brew-upgrade branch from fab5f33 to b4e04c0 Compare May 6, 2026 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants