This repository was archived by the owner on Apr 22, 2025. It is now read-only.
Implement brew bundle remove
#1640
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlocab
changed the title
brew bundle remove [WIP]brew bundle remove
carlocab
commented
Mar 10, 2025
There was a problem hiding this comment.
PR Overview
This PR implements a new "brew bundle remove" command to allow removal of entries from the Brewfile. Key changes include:
- Addition of a test case for the remove command in spec/bundle/commands/remove_command_spec.rb.
- Implementation of the remove logic in lib/bundle/remover.rb and its exposure via lib/bundle/commands/remove.rb.
- Updates in cmd/bundle.rb and lib/bundle.rb to integrate the new "remove" subcommand.
Reviewed Changes
| File | Description |
|---|---|
| spec/bundle/commands/remove_command_spec.rb | Adds tests to verify removal of entries from a Brewfile. |
| lib/bundle/remover.rb | Implements the removal functionality from the Brewfile using regex filtering. |
| lib/bundle/commands/remove.rb | Forwards the remove call to the Remover module. |
| cmd/bundle.rb | Updates subcommand handling to include "remove" and maps type flags accordingly. |
| lib/bundle.rb | Requires new modules to support the remove functionality. |
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Part of #818 Co-authored-by: Copilot <[email protected]>
MikeMcQuaid
approved these changes
Mar 11, 2025
carlocab
added a commit
that referenced
this pull request
Mar 12, 2025
… `--formula` Follow-up to #1640
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #818