5kplayer: 6.10.0, auto_updates and fix livecheck #205297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: livecheck differs, will fix. Don't merge yet. |
|
Additional notes: it seems the disk image contains a folder named .HFS+ Private Directory Data?, which brew struggles with. I'll probably have to open an issue in homebrew/brew. |
bevanjkay
reviewed
Mar 18, 2025
bevanjkay
reviewed
Mar 18, 2025
eleanordoesntcode
force-pushed
the
tests
branch
from
cc30ba1 to
1b3a264
Compare
eleanordoesntcode
changed the title
|
I think we may need to wait for the next Brew release to merge this, because the fix for the installation won't be generally available yet. |
|
Alright! |
|
I pushed a small update to modify the |
bevanjkay
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
App does have an auto-updater (seen in-app).