-
-
Notifications
You must be signed in to change notification settings - Fork 12.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quictls 3.0.9 (new formula) #134975
quictls 3.0.9 (new formula) #134975
Conversation
These should be two separate PRs |
We're phasing out OpenSSL 1.1.1 ahead of its upcoming EOL, so I don't think we should be adding a 1.1.1 for this. |
@carlocab Tests still fail because of full audit |
Yes, I can see that, thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm ok with merging this as-is.
We can add this to the allowlist to fix the make check
/make test
audit failure, but the fork failure can't be made to go away here.
Note, however, that I'm only ok with merging this as long as we do not use this as a dependency for other formulae. All formulae should continue to use upstream OpenSSL as long as that continues to be supported.
@Bo98 We may still need to use OpenSSL 1.1.x for a while until the performance issues are mitigated. |
OpenSSL 3.x is what it is, performance issues and all and soon it'll be the only supported version and Homebrew plans to abide by that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apologies for the delay here. I was waiting for Homebrew/brew#15614 to land. There's some extra changes needed, but I'll follow-up on those. Let's get this merged.
This is a TLS library, so we run `make test`. Companion to Homebrew#134975.
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?The latest
NodeJS
(#89068 #89459) andHaproxy
v2.8 use quictls to support the QUIC protocol.The formula is is a copy of openssl, so can't pass the
brew audit
either.Can we temporarily turn off this warning to run through the functional tests for each platform ?