Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

quictls 3.0.9 (new formula) #134975

Merged
merged 2 commits into from
Jul 19, 2023
Merged

quictls 3.0.9 (new formula) #134975

merged 2 commits into from
Jul 19, 2023

Conversation

flier
Copy link
Contributor

@flier flier commented Jun 26, 2023

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

The latest NodeJS (#89068 #89459) and Haproxy v2.8 use quictls to support the QUIC protocol.
The formula is is a copy of openssl, so can't pass the brew audit either.

$ brew audit --strict --new-formula --online quictls
quictls
  * line 90, col 5: Formulae in homebrew/core (except e.g. cryptography, libraries) should not run build-time checks
  * GitHub fork (not canonical repository)

Can we temporarily turn off this warning to run through the functional tests for each platform ?

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core legacy Relates to a versioned @ formula labels Jun 26, 2023
@SMillerDev
Copy link
Member

These should be two separate PRs

@SMillerDev SMillerDev changed the title Quictls 1.1.1u & 3.0.9 Quictls 1.1.1u & 3.0.9 (new formulae) Jun 26, 2023
@Bo98
Copy link
Member

Bo98 commented Jun 26, 2023

We're phasing out OpenSSL 1.1.1 ahead of its upcoming EOL, so I don't think we should be adding a 1.1.1 for this.

@github-actions github-actions bot removed the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 27, 2023
@github-actions github-actions bot added the new formula PR adds a new formula to Homebrew/homebrew-core label Jun 27, 2023
@github-actions github-actions bot removed automerge-skip `brew pr-automerge` will skip this pull request legacy Relates to a versioned @ formula labels Jun 27, 2023
@flier flier changed the title Quictls 1.1.1u & 3.0.9 (new formulae) Quictls 3.0.9 (new formulae) Jun 27, 2023
@carlocab carlocab changed the title Quictls 3.0.9 (new formulae) quictls 3.0.9 (new formulae) Jun 27, 2023
@carlocab carlocab changed the title quictls 3.0.9 (new formulae) quictls 3.0.9 (new formula) Jun 27, 2023
Formula/quictls.rb Outdated Show resolved Hide resolved
Formula/quictls.rb Outdated Show resolved Hide resolved
Formula/quictls.rb Outdated Show resolved Hide resolved
Formula/quictls.rb Outdated Show resolved Hide resolved
Formula/quictls.rb Outdated Show resolved Hide resolved
Formula/quictls.rb Outdated Show resolved Hide resolved
@carlocab carlocab added audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. labels Jun 28, 2023
@flier
Copy link
Contributor Author

flier commented Jul 1, 2023

@carlocab Tests still fail because of full audit

@carlocab
Copy link
Member

carlocab commented Jul 1, 2023

Yes, I can see that, thanks.

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm ok with merging this as-is.

We can add this to the allowlist to fix the make check/make test audit failure, but the fork failure can't be made to go away here.

Note, however, that I'm only ok with merging this as long as we do not use this as a dependency for other formulae. All formulae should continue to use upstream OpenSSL as long as that continues to be supported.

@carlocab carlocab added the maintainer feedback Additional maintainers' opinions may be needed label Jul 1, 2023
@flier
Copy link
Contributor Author

flier commented Jul 3, 2023

I'm ok with merging this as-is.

We can add this to the allowlist to fix the make check/make test audit failure, but the fork failure can't be made to go away here.

Note, however, that I'm only ok with merging this as long as we do not use this as a dependency for other formulae. All formulae should continue to use upstream OpenSSL as long as that continues to be supported.

We're phasing out OpenSSL 1.1.1 ahead of its upcoming EOL, so I don't think we should be adding a 1.1.1 for this.

@Bo98 We may still need to use OpenSSL 1.1.x for a while until the performance issues are mitigated.

openssl/openssl#17627

@SMillerDev
Copy link
Member

We may still need to use OpenSSL 1.1.x for a while until the performance issues are mitigated.

OpenSSL 3.x is what it is, performance issues and all and soon it'll be the only supported version and Homebrew plans to abide by that.

@github-actions
Copy link
Contributor

Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay here. I was waiting for Homebrew/brew#15614 to land. There's some extra changes needed, but I'll follow-up on those. Let's get this merged.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 19, 2023
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 19, 2023
Merged via the queue into Homebrew:master with commit c31108a Jul 19, 2023
12 checks passed
carlocab added a commit to carlocab/homebrew-core that referenced this pull request Jul 19, 2023
This is a TLS library, so we run `make test`.

Companion to Homebrew#134975.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
audit failure CI fails while auditing the software CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. maintainer feedback Additional maintainers' opinions may be needed new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants