libtirpc: make formula work on macos #192861
Open
+280
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this changes the formula to not compile only on linux. on macos, the bundled kerberos is used. because the necessary changes for this to work are not yet upstream, configure must be regenerated, so aclocal, autoconf and automake will need to be run; we set an environment to allow that. this includes an inline copy of patches which were submitted to libtirpc-devel list for inclusion (upstream does not use github so i had to do this rather than PR)
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
carlocab
reviewed
Oct 5, 2024
Comment on lines
+24
to
+25
| ENV["ACLOCAL"] = "aclocal" | ||
| ENV["AUTOMAKE"] = "automake" |
There was a problem hiding this comment.
Why do we need to specify these environment variables? Under what names does it look for aclocal and automake without it?
| depends_on "pkg-config" => :build | ||
|
|
||
| uses_from_macos "krb5" | ||
| patch :DATA # all patches were sent to libtirpc-devel during the 1.3.6 cycle |
There was a problem hiding this comment.
Do you have a link to the thread on the mailing list? Can you add it in a comment?
| ENV["ACLOCAL"] = "aclocal" | ||
| ENV["AUTOMAKE"] = "automake" | ||
| ENV.append_path "ACLOCAL_PATH", "config" | ||
| system "autoreconf", "-ivf" |
There was a problem hiding this comment.
Suggested change
| system "autoreconf", "-ivf" | |
| system "autoreconf", "--force", "--install", "--verbose" |
carlocab
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this changes the formula to not compile only on linux. on macos, the bundled kerberos is used. because the necessary changes for this to work are not yet upstream, configure must be regenerated, so aclocal, autoconf and automake will need to be run; we set an environment to allow that. this includes an inline copy of patches which were submitted to libtirpc-devel list for inclusion (upstream does not use github so i had to do this rather than PR)
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?