fcft 3.1.8 (new formula) #192887
fcft 3.1.8 (new formula) #192887
Conversation
github-actions
bot
added
the
new formula
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
david
force-pushed
the
add-fcft-library
branch
3 times, most recently
from
3edf5c9
to
535be71
Compare
|
Updated to build on Linux only, due to the dependency on threads.h. |
Formula/f/fcft.rb
Outdated
| depends_on "fontconfig" | ||
| depends_on "freetype" | ||
| depends_on "harfbuzz" | ||
| depends_on :linux |
There was a problem hiding this comment.
Can't see where this requires Linux -- do you know where the source relies on this?
There was a problem hiding this comment.
The failed MacOSX CI test complained about the missing threads.h header, which is included in fcft.h and is part of the Linux headers. I did not find any direct mention to the constants defined in that file, though.
There was a problem hiding this comment.
I see. That sounds something that can be easily fixed upstream. I remember @cho-m handling this issue for another formula recently.
There was a problem hiding this comment.
Ok, I opened an issue on fcft's repo to see if we can clarify this.
There was a problem hiding this comment.
Ok, according to fcft's author this is just a matter of using a compiler and libc that supports threads.h, so I changed the dependencies on mac to use both gcc and glibc. I don't know if this is the right way to do it, so please let me know how to proceed, whenever it's convenient for you.
david
force-pushed
the
add-fcft-library
branch
2 times, most recently
from
b2b1625
to
baf2f82
Compare
|
Moving this to ready for review, as #192886 has been merged and tests are passing. |
david
force-pushed
the
add-fcft-library
branch
from
baf2f82
to
45ecf8d
Compare
david
force-pushed
the
add-fcft-library
branch
from
45ecf8d
to
313670a
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?This is a prerequisite for merging #192675 and requires #192886 to be merged first.