Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-cli: generate completions for all shells #192912

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

maxbrunet
Copy link

This switches to generate the completion with register-python-argcomplete directly, similarly to other Python tools like pipx.

The az.completion.sh script is not the actual completion, but runs eval: https://github.com/Azure/azure-cli/blob/azure-cli-2.60.0/src/azure-cli/az.completion.sh#L11

This also adds completion support for zsh and fish.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue labels Oct 5, 2024
@carlocab
Copy link
Member

carlocab commented Oct 5, 2024

Can you also send a PR to update https://github.com/Azure/azure-cli/blob/dev/scripts/release/homebrew/docker/formula_template.txt? Otherwise upstream automation will just overwrite this on their next PR.

@maxbrunet
Copy link
Author

Thank you @carlocab for the heads up, I have opened Azure/azure-cli#30032

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Python use is a significant feature of the PR or issue rust Rust use is a significant feature of the PR or issue shell-completion
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants