-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
diary 0.15 (new formula) #204366
diary 0.15 (new formula) #204366
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
76f01cb
to
bcbde2a
Compare
543d7dc
to
d774f06
Compare
d774f06
to
dcac605
Compare
Thank you for the improvements @chenrui333 much appreciated |
dcac605
to
af2e7f7
Compare
3636f4a
to
6757fba
Compare
6757fba
to
9db3e62
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a minor comment for consistency with other livecheck
blocks, but otherwise looks good to me – thanks!
diary: consistency with other livecheck blocks diary: fix brew style, tap syntax diary: assert shell stderr output diary: improve tests diary: update deps and livecheck Co-authored-by: Nanda H Krishna <[email protected]> Signed-off-by: Rui Chen <[email protected]>
40cb319
to
493a07b
Compare
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Requesting to add latest diary v0.15. Thank you for review.