-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
evil-helix 20250104 (new formula) #204642
base: master
Are you sure you want to change the base?
Conversation
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
ac6597a
to
e10474d
Compare
The versioning way is different between the package source and release tag. Even if I read the version from the |
aha, maybe worth an upstream issue report. |
Any chance to get the 2nd required review? |
The problem isn't the amount of reviews, it's a failing build. |
Thanks, @SMillerDev. I fixed the version test in the formula to match upstream. I saw others were not happy how upstream is handling version information in source vs release tag. Tend to agree, but it shouldn't block this PR IMO. |
So, I guess now it only takes an approval to merge? How can we proceed? Thanks! |
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>
)? If this is a new formula, does it passbrew audit --new <formula>
?Another attempt (#204608 didn't work).