Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bold 0.1.0 (new formula) #204696

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

bold 0.1.0 (new formula) #204696

wants to merge 1 commit into from
+49 −0

Conversation

chenrui333
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@chenrui333 chenrui333 added new formula PR adds a new formula to Homebrew/homebrew-core automerge-skip `brew pr-automerge` will skip this pull request zig Zig use is a significant feature of the PR or issue autobump macos-only Formula depends on macOS ready to merge PR can be merged once CI is green labels Jan 18, 2025
carlocab
carlocab reviewed Jan 18, 2025
View reviewed changes
Formula/b/bold.rb
license "MIT"

depends_on "zig" => :build
depends_on :macos
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like this should build on Linux too. Why make it macOS-only?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this is only for apple system linker replacement?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request macos-only Formula depends on macOS new formula PR adds a new formula to Homebrew/homebrew-core ready to merge PR can be merged once CI is green zig Zig use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@chenrui333 @carlocab