Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm 20.1.1 #206362

Merged
merged 42 commits into from
Mar 31, 2025
Merged

llvm 20.1.1 #206362

merged 42 commits into from
Mar 31, 2025

Conversation

carlocab
Copy link
Member

@carlocab carlocab commented Feb 3, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • llvm 20.1.0-rc1
  • flang 20.1.0-rc1
  • lld 20.1.0-rc1
  • unstable_allowlist: add llvm

Closes #217306

@carlocab carlocab added prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. long build Set a long timeout for formula testing labels Feb 3, 2025
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Feb 3, 2025
@carlocab carlocab added the CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. label Feb 3, 2025
@carlocab carlocab force-pushed the llvm-20 branch 2 times, most recently from fdd4fb8 to c81394a Compare February 4, 2025 19:42
@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core long dependent tests Set a long timeout for dependent testing labels Feb 19, 2025
@carlocab carlocab force-pushed the llvm-20 branch 2 times, most recently from fce2292 to c9de27e Compare February 19, 2025 09:03
@carlocab carlocab changed the title llvm 20.1.0-rc1 llvm 20.1.0-rc2 Feb 19, 2025
@lukeshingles
Copy link
Contributor

lukeshingles commented Mar 5, 2025

LLVM 20.1 final got released a week early. https://github.com/llvm/llvm-project/releases/tag/llvmorg-20.1.0

The CI was last run on rc2, so rc3/final might fix some things automatically, but a couple of notes from the logs:

  • afl++ and ldc builds are somehow still linking against libLLVM v20.1, which leads to a missing z3 library (dep of llvm but not llvm@19).
brew install --only-dependencies --verbose --formula --build-bottle afl++
dyld[34548]: Library not loaded: /opt/homebrew/opt/z3/lib/libz3.4.13.dylib
  Referenced from: <397F4426-1635-31E0-978B-ED0A3B7B0957> /opt/homebrew/Cellar/llvm/20.1.0-rc2/lib/libLLVM.dylib
  Reason: tried: '/opt/homebrew/opt/z3/lib/libz3.4.13.dylib' (no such file), '/System/Volumes/Preboot/Cryptexes/OS/opt/homebrew/opt/z3/lib/libz3.4.13.dylib' (no such file), '/opt/homebrew/opt/z3/lib/libz3.4.13.dylib' (no such file), '/usr/local/lib/libz3.4.13.dylib' (no such file), '/usr/lib/libz3.4.13.dylib' (no such file, not in dyld cache)
  • wasi-runtimes might need to have the dep reverted from llvm to llvm@19
  • halide and wasmedge errors like they might need a legacy lld@19 added so that the CMake finds the correct version of llvm (searching for 20.1 and found 19.1 from llvm@19)
 CMake Error at /opt/homebrew/lib/cmake/lld/LLDConfig.cmake:10 (find_package):
    Could not find a configuration file for package "LLVM" that exactly matches
    requested version "20.1.0".
  
    The following configuration files were considered but not accepted:
  
      /opt/homebrew/opt/llvm@19/lib/cmake/llvm/LLVMConfig.cmake, version: 19.1.7
      /opt/homebrew/opt/llvm@19/lib/cmake/llvm/llvm-config.cmake, version: unknown

@FabioFracassi
Copy link

This issue #196905 is probably relevant here again. Only now brew install llvm --HEAD should be labeled llvm@21 otherwise users can not install latest head and latest stable side by side.

@fxcoudert fxcoudert marked this pull request as ready for review March 14, 2025 14:55
@fxcoudert fxcoudert requested a review from a team as a code owner March 14, 2025 14:55
@fxcoudert fxcoudert removed the prerelease-testing Pull request from upstream, testing a pre-release with homebrew dependencies label Mar 14, 2025
@fxcoudert fxcoudert changed the title llvm 20.1.0-rc2 llvm 20.1.0 Mar 14, 2025
@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 14, 2025
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Mar 14, 2025
@michaelaeriksen
Copy link

Any plans to release this? 20.1.2 is just around the corner April 1st

@MikeMcQuaid
Copy link
Member

@michaelaeriksen CI is failing here. If you can help move it along: we'd welcome that. Otherwise: it can't be merged until it's working.

@MikeMcQuaid
Copy link
Member

Going to merge this and follow up on the remaining 2 formulae:

@cho-m sounds good, thanks!

For split, there has been previous discussion but just that no one has tried it out yet

I'd be 👎🏻 on split before we've tried versioning.

For versioning, will need to make sure the compiler selection and special brew handling of LLVM works correctly. Mainly checking that the alias will be used correctly everywhere. Also may need to decide on what to do with HEAD

Yup, thanks for spelling that out. Think it's worthwhile, though.

At this point: anything that takes >= 1 week to deal with dependency revision bumps is probably worth moving to being a versioned formula.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Mar 31, 2025
@BrewTestBot BrewTestBot enabled auto-merge March 31, 2025 12:46
@BrewTestBot BrewTestBot added this pull request to the merge queue Mar 31, 2025
Merged via the queue into master with commit 5bf2bd5 Mar 31, 2025
14 checks passed
@BrewTestBot BrewTestBot deleted the llvm-20 branch March 31, 2025 12:56
@chenrui333 chenrui333 mentioned this pull request Apr 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-linux-self-hosted Build on Linux self-hosted runner CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. long build Set a long timeout for formula testing long dependent tests Set a long timeout for dependent testing no long build conflict Do not allow merging other pull requests when files conflict with this one ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants