qt: Change QT_FEATURE to FEATURE

[LecrisUT]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

The QT_FEATURE bypasses some of the checks that are made when initializing the features, e.g. FEATURE_static and FEATURE_shared are mutually exclusive.

There was also a patch that seemed to be outdated based on the linked bug.

[LecrisUT]

Welp, can't figure out what's wrong with Commit style check. I have tried with both Qt: and qt: and other possible complaints, but nothing satisfied it.

[p-linnane]

Welp, can't figure out what's wrong with Commit style check. I have tried with both Qt: and qt: and other possible complaints, but nothing satisfied it.

From the Formula Cookbook:

One formula per commit; one commit per formula.
Keep merge commits out of the pull request.

Please squash your commits.

[LecrisUT]

Please squash your commits.

Oh right, always forget that point 🙁. Anyways there is a more important task of getting it to work since it seems changing this did detect an incompatibility. Even if it could be a false-positive, it would be good to report it if so. Anyone familiar with how this was configured for homebrew could pitch in and look at the error messages? The immediate error seems is with unnecessary dependency and is dropped in later versions ¹.

Footnotes

1. https://github.com/qt/qtwebengine/commit/66cdfc11b13efdc4d867aad066ca4677869fd927 ↩