visp: update postinstall to support API #208554
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like #208060 only worked via tap since JSON API has
bottle == nil
.Not sure if there is a better way, but trying to parse OS information from tab (e.g.
os_version
ismacOS 14.7
).Also provide output similar to keg relocation.
odebug
would be better but looks like we never added support for that in postinstall.Output would look like:
One issue is output is always shown, even with
brew postinstall visp --quiet
. May want to consider adding odebug support first to avoid this.Note that
odebug
in current brew postinstall is pretty much a code comment since--debug
is dropped when executingpostinstall.rb
.