nmstatectl 2.2.42 (new formula) #210338
nmstatectl 2.2.42 (new formula) #210338
Conversation
Signed-off-by: Ben Dronen <[email protected]>
github-actions
bot
added
new formula
| end | ||
|
|
||
| test do | ||
| system bin/"nmstatectl", "version" |
There was a problem hiding this comment.
We need a test that exercises the some of the functionality of the app. Version checks or usage checks (foo --version or foo --help) are not sufficient, as explained in the formula cookbook.
In most cases, a good test would involve running a simple test case: run #{bin}/foo input.txt.
- Then you can check that the output is as expected (with assert_equal or assert_match on the output of shell_output)
- You can also check that an output file was created, if that is expected: assert_predicate teadd-gurkath/"output.txt", :exist?
Some advice for specific cases:
- If the formula is a library, compile and run some simple code that links against it. It could be taken from upstream's documentation / source examples.
- If the formula is for a GUI program, try to find some function that runs as command-line only, like a format conversion, reading or displaying a config file, etc.
- If the software cannot function without credentials, a test could be to try to connect with invalid credentials (or without credentials) and confirm that it fails as expected.
- Same if the software requires a virtual machine, docker instance, etc. to be running.
There was a problem hiding this comment.
thanks for the feedback, will add better testing
|
|
||
| def install | ||
| cd "rust/src/cli" do | ||
| system "cargo", "install", "--no-default-features", "--features", "gen_conf", *std_cargo_args if OS.mac? |
There was a problem hiding this comment.
what is the issue with the default features?
There was a problem hiding this comment.
@chenrui333 nmstatectl is designed to create and apply NetworkManager configurations. On macOS, the only feature enabled is the ability to generate nmconnection files: https://github.com/nmstate/nmstate/blob/base/.github/workflows/release.yml#L37-L38
| depends_on "rust" => :build | ||
|
|
||
| def install | ||
| cd "rust/src/cli" do |
There was a problem hiding this comment.
you can also cd "rust" and specify src/cli as path param for std_cargo_args
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?