Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pypy3.11 7.3.17 (new formula) #211062

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

pypy3.11 7.3.17 (new formula) #211062

wants to merge 2 commits into from

Conversation

carlocab
Copy link
Member

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • pypy3.11 7.3.17 (new formula)
  • pypy3.10: revision bump (pypy3 symlink update)

@carlocab carlocab added CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. labels Mar 16, 2025
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core labels Mar 16, 2025
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 16, 2025
@carlocab carlocab requested a review from Copilot March 16, 2025 08:55
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new formula for PyPy 3.11 (version 7.3.17) and bumps the revision for the PyPy 3.10 formula. Key changes include:

  • Adding a new formula file for PyPy 3.11 with installation, patch, and post-install modifications.
  • Updating the PyPy 3.10 formula with a revision bump and an updated pip resource.
  • Consolidating the ABI version helper methods in PyPy formulas for consistency.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Formula/p/pypy3.11.rb New formula for PyPy 3.11 including installation, patch adjustments, and post-install steps.
Formula/p/pypy3.10.rb Revision bump and pip resource update; removal of duplicate ABI helper method definitions.
Comments suppressed due to low confidence (2)

Formula/p/pypy3.11.rb:4

  • The pypy3.11 formula is using a URL that references pypy3.10. Verify that this is intended; if not, update the URL to point to the correct pypy3.11 source archive.
url "https://downloads.python.org/pypy/pypy3.10-v7.3.17-src.tar.bz2"

Formula/p/pypy3.11.rb:237

  • [nitpick] Using a hardcoded 'if False:' to disable Linux tcl-tk detection may be too broad; consider explicitly checking for the Linux platform or adding a more detailed comment referencing the upstream issue to improve clarity.
if False: # disable Linux system tcl-tk detection

@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 16, 2025
@carlocab carlocab removed the automerge-skip `brew pr-automerge` will skip this pull request label Mar 16, 2025
@botantony
Copy link
Contributor

pip resource lacks setup.py file in root directory

@carlocab
Copy link
Member Author

pip resource lacks setup.py file in root directory

Yea, we'll probably have to do something similar to what [email protected] does for pip.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-skip-new-formulae Pass --skip-new to brew test-bot. CI-skip-new-formulae-strict Pass --skip-new-strictw to brew test-bot. new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants