Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libadwaita 1.7.0 #211138

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

libadwaita 1.7.0 #211138

wants to merge 1 commit into from

Conversation

samford
Copy link
Member

@samford samford commented Mar 17, 2025

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

libadwaita is in the autobump list but it can't be bumped to 1.7.0 until the version in the audit allowlist is updated to 1.7. This updates the allowlist and manually updates the formula.

`libadwaita` is in the autobump list but it can't be bumped to 1.7.0
until the version in the audit allowlist is updated to 1.7. This
updates the allowlist and manually updates the formula.
@github-actions github-actions bot added the automerge-skip `brew pr-automerge` will skip this pull request label Mar 17, 2025
@samford
Copy link
Member Author

samford commented Mar 17, 2025

Build failing with:

Usage: g-ir-scanner [options] sources
  
g-ir-scanner: error: no such option: --doc-format

This comes from src/meson.build:

libadwaita_gir_extra_args = [
  '--quiet',
  '--doc-format=gi-docgen',
  '-DADWAITA_COMPILATION',
]

@daeho-ro
Copy link
Member

Maybe new version is required

@samford
Copy link
Member Author

samford commented Mar 17, 2025

Thanks for the heads up. I tested it locally and libadwaita 1.7.0 builds as expected with gobject-introspection 1.84.0. I'll rebase this once that PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants