Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

openjdk 24 #212057

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

openjdk 24 #212057

wants to merge 1 commit into from

Conversation

calvinit
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

Java 24 / JDK 24: General Availability.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. labels Mar 20, 2025
@calvinit
Copy link
Contributor Author

Here are some logs from the "Post-build steps" CI job on macOS.
It is unclear whether we need to pay special attention to and address them:

==> Summary
/usr/local/Cellar/gnu-tar/1.35: 17 files, 1.8MB
==> Running `brew cleanup gnu-tar`...
==> Determining openjdk bottle rebuild...
==> Bottling openjdk--24.sonoma.bottle.tar.gz...
Error: Failed applying an ad-hoc signature to /usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib:
/usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib: replacing existing signature
/usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib: resource fork, Finder information, or similar detritus not allowed


/usr/local/opt/gnu-tar/bin/gtar --create --numeric-owner --mtime=2025-02-06 00:16:21 --sort=name --owner=0 --group=0 --numeric-owner --format=pax --pax-option=globexthdr.name=/GlobalHead.%n,exthdr.name=%d/PaxHeaders/%f,delete=atime,delete=ctime --file /Users/brew/actions-runner/_work/homebrew-core/homebrew-core/bottles/openjdk--24.sonoma.bottle.tar openjdk/24
==> Detecting if openjdk--24.sonoma.bottle.tar.gz is relocatable...
Error: Failed applying an ad-hoc signature to /usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib:
/usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib: replacing existing signature
/usr/local/Cellar/openjdk/24/libexec/openjdk.jdk/Contents/MacOS/libjli.dylib: resource fork, Finder information, or similar detritus not allowed

@fxcoudert fxcoudert added CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests. labels Mar 20, 2025
@fxcoudert
Copy link
Member

Gradle failure on Linux. Upstream issue: gradle/gradle#32290

@calvinit
Copy link
Contributor Author

Gradle failure on Linux. Upstream issue: gradle/gradle#32290

Yes, I found that many failures are caused by the lack of support for the latest OpenJDK 24. This raises the question: should we rely on many non-LTS OpenJDK versions as their JVM environment (depends_on "openjdk")? After all, STS (Short-Term Support) only provides six months of support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge-skip `brew pr-automerge` will skip this pull request CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-no-fail-fast-deps Continue dependent tests despite failing GitHub Actions matrix tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants