Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

spotifyd 0.4.1 #212860

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

spotifyd 0.4.1 #212860

wants to merge 1 commit into from
+50 −19

Conversation

BrewTestBot
Copy link
Member

Created by brew bump

Created with brew bump-formula-pr.

release notes 
This release fixes several problems and oversights of the last major release.

Fixed


    

  • revert default features to alsa_backend (#1337)
    • 

  • do not require bindgen dependencies on supported systems (#1340)
    • 

  • always return exitcode 1 on error (#1338)
    • 

  • the released binaries for linux-x86_64 will now also work for older systems (#1342)
    •

@github-actions github-actions bot added rust Rust use is a significant feature of the PR or issue bump-formula-pr PR was created using `brew bump-formula-pr` labels Mar 21, 2025
@cho-m cho-m force-pushed the bump-spotifyd-0.4.1 branch from da4a901 to 33ea855 Compare March 21, 2025 04:28
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request autobump labels Mar 21, 2025
@cho-m cho-m marked this pull request as draft March 21, 2025 04:42
@cho-m cho-m force-pushed the bump-spotifyd-0.4.1 branch from 33ea855 to c995e3c Compare March 21, 2025 05:08
@cho-m cho-m added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Mar 21, 2025
@cho-m cho-m force-pushed the bump-spotifyd-0.4.1 branch from c995e3c to be89903 Compare March 21, 2025 05:30
cho-m
cho-m reviewed Mar 21, 2025
View reviewed changes
Formula/s/spotifyd.rb Outdated
Comment on lines 55 to 56
run macos: [opt_bin/"spotifyd", "--no-daemon", "--backend", "portaudio"],
linux: [opt_bin/"spotifyd", "--no-daemon", "--backend", "pulseaudio"]
Copy link
Member

@cho-m cho-m Mar 21, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at switching to:

Suggested change
run macos: [opt_bin/"spotifyd", "--no-daemon", "--backend", "portaudio"],
linux: [opt_bin/"spotifyd", "--no-daemon", "--backend", "pulseaudio"]
run [opt_bin/"spotifyd", "--no-daemon", "--config-path", etc/"spotifyd.conf"]

Still deciding on what is best default for Linux. Our prior choice of Portaudio was a bit odd as it is usually not used on Linux.

@cho-m cho-m force-pushed the bump-spotifyd-0.4.1 branch from be89903 to 25316be Compare March 21, 2025 06:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cho-m cho-m cho-m left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
autobump automerge-skip `brew pr-automerge` will skip this pull request bump-formula-pr PR was created using `brew bump-formula-pr` CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. rust Rust use is a significant feature of the PR or issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrewTestBot @cho-m