Skip to content

quantum++ 6.0 #220081

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025
Merged

quantum++ 6.0 #220081

merged 2 commits into from
Apr 17, 2025

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created with brew bump-formula-pr.

release notes

@github-actions github-actions bot added the bump-formula-pr PR was created using `brew bump-formula-pr` label Apr 14, 2025
@botantony
Copy link
Contributor

depends_on "googletest" => :build

@vsoftco
Copy link
Contributor

vsoftco commented Apr 15, 2025

@botantony Do you mind please adding the dependency to the formula ruby file? Thanks!!

@botantony
Copy link
Contributor

diff --git a/Formula/q/quantum++.rb b/Formula/q/quantum++.rb
index 8c9df88f4d7..8e8e6cde74e 100644
--- a/Formula/q/quantum++.rb
+++ b/Formula/q/quantum++.rb
@@ -1,19 +1,27 @@
 class Quantumxx < Formula
   desc "Modern C++ quantum computing library"
   homepage "https://github.com/softwareQinc/qpp"
-  url "https://github.com/softwareQinc/qpp/archive/refs/tags/v5.1.tar.gz"
-  sha256 "971483eefbf5e4d427553276d9bfd237e3d22ea8757a1ee7afa25417aca158ea"
+  url "https://github.com/softwareQinc/qpp/archive/refs/tags/v6.0.tar.gz"
+  sha256 "cdd6acf287b2f2dd124120ef2aba85660eee9482f5484dbd229c93b53a7d8a54"
   license "MIT"
+  head "https://github.com/softwareQinc/qpp.git", branch: "main"
 
   bottle do
     sha256 cellar: :any_skip_relocation, all: "0ff3efd01b8a28045694ee46bc49bdbf510652e6318fcf3a7976b545aed1e53d"
   end
 
   depends_on "cmake" => [:build, :test]
+  depends_on "googletest" => :build
   depends_on "eigen"
+  depends_on "pybind11"
 
   def install
-    system "cmake", "-S", ".", "-B", "build", *std_cmake_args
+    args = %w[
+      -DFETCHCONTENT_FULLY_DISCONNECTED=OFF
+      -DHOMEBREW_ALLOW_FETCHCONTENT=ON
+    ]
+    system "cmake", "-S", ".", "-B", "build", *args, *std_cmake_args
+    system "cmake", "--build", "build"
     system "cmake", "--install", "build"
   end
 
@@ -29,7 +37,7 @@ class Quantumxx < Formula
     CMAKE
     (testpath/"qpp_test.cpp").write <<~CPP
       #include <iostream>
-      #include <qpp/qpp.h>
+      #include <qpp/qpp.hpp>
 
       int main() {
           using namespace qpp;

@botantony
Copy link
Contributor

oh, i see it is a header-only library, system "cmake", "--build", "build" can be removed

@vsoftco
Copy link
Contributor

vsoftco commented Apr 15, 2025

oh, i see it is a header-only library, system "cmake", "--build", "build" can be removed

Agree. It's only there for Windows compatibility (although brew doesn't support Windows yet), since on Win, cmake --install build doesn't work (or at least didn't use to work when I was testing it), so one needed the cmake --build build --target install instead.

@daeho-ro daeho-ro force-pushed the bump-quantum++-6.0 branch from 9ad8078 to ecc3fc0 Compare April 16, 2025 15:25
@vsoftco
Copy link
Contributor

vsoftco commented Apr 16, 2025

Thanks for the fix @botantony @daeho-ro !

@daeho-ro daeho-ro added the ready to merge PR can be merged once CI is green label Apr 17, 2025
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 17, 2025
@BrewTestBot BrewTestBot enabled auto-merge April 17, 2025 07:22
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 17, 2025
Merged via the queue into master with commit e0f925a Apr 17, 2025
14 checks passed
@BrewTestBot BrewTestBot deleted the bump-quantum++-6.0 branch April 17, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump-formula-pr PR was created using `brew bump-formula-pr` CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. ready to merge PR can be merged once CI is green
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants