Skip to content

emscripten: update resources #220109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025
Merged

emscripten: update resources #220109

merged 2 commits into from
Apr 16, 2025

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 15, 2025

Also:

  • Switch binaryen to archive tarball. Git modules are for tests which can be disabled by -DBUILD_TESTS=OFF and mimalloc (default disabled)
  • Add some resource livechecks to try to better track updates. This may still need manual updates as they are versioned by git commit
  • Fix for arm64 linux build

Livecheck could be improved in future:

  • should ideally use formula latest version but didn't find a way to get it within resource strategy
  • would be nicer to cache same URL query to avoid duplicate GET requests
  • also should improve handling of git commit as version information since this is quite common

Also:
* Switch `binaryen` to archive tarball. Git modules are for tests which
  can be disabled by `-DBUILD_TESTS=OFF` and mimalloc (default disabled)
* Add some resource livechecks to try to better track updates. This may
  still need manual updates as they are versioned by git commit
* Fix for arm64 linux build
@cho-m cho-m added the livecheck Issues or PRs related to livecheck label Apr 15, 2025
@github-actions github-actions bot added nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue java Java use is a significant feature of the PR or issue CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. long build Set a long timeout for formula testing labels Apr 15, 2025
@daeho-ro daeho-ro mentioned this pull request Apr 16, 2025
1 task
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 16, 2025
@BrewTestBot BrewTestBot enabled auto-merge April 16, 2025 13:20
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 16, 2025
Merged via the queue into master with commit a1fb394 Apr 16, 2025
14 checks passed
@BrewTestBot BrewTestBot deleted the emscripten-update-resources branch April 16, 2025 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-build-dependents-from-source Pass --build-dependents-from-source to brew test-bot. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. java Java use is a significant feature of the PR or issue livecheck Issues or PRs related to livecheck long build Set a long timeout for formula testing nodejs Node or npm use is a significant feature of the PR or issue python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants