Skip to content

miniflux 2.2.7 (new formula) #220115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

IngmarStein
Copy link

Miniflux is a minimalist and opinionated feed reader.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core labels Apr 15, 2025
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@botantony
Copy link
Contributor

botantony commented Apr 15, 2025

Change install to

ldflags = %W[
    -s -w
    -X miniflux.app/v2/internal/version.Version=#{version}
    -X miniflux.app/v2/internal/version.Commit=#{tap.user}
    -X miniflux.app/v2/internal/version.BuildDate=#{time.iso8601}
]
system "go", "build", *std_go_args(ldflags:)

It should fix broken installation.

And can you create come up with a better test?

From Formula Cookbook:

We want tests that don’t require any user input and test the basic functionality of the application. For example foo build-foo input.foo is a good test and (despite their widespread use) foo --version and foo --help are bad tests.

@IngmarStein IngmarStein force-pushed the miniflux branch 8 times, most recently from 7867ab1 to 6947c0c Compare April 15, 2025 15:46
[Miniflux](https://miniflux.app/) is a minimalist and opinionated feed reader.
@IngmarStein
Copy link
Author

@botantony

It should fix broken installation.

Alright, the CI is green now.

And can you create come up with a better test?

This is now running the full integration test suite against the compiled binary. It required spinning up a temporary Postgres instance, but several other formulae do that too.

@IngmarStein IngmarStein requested a review from daeho-ro April 16, 2025 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Go use is a significant feature of the PR or issue new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants