Skip to content

ramalama: depend on llama.cpp #220129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

ericcurtin
Copy link
Contributor

To achieve maximum inferencing performance this package is required.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. python Python use is a significant feature of the PR or issue labels Apr 15, 2025
@ericcurtin ericcurtin force-pushed the llamacpp-dep-ramalama branch from 8adf366 to 523371b Compare April 15, 2025 10:39
To achieve maximum inferencing performance this
package is required.

Signed-off-by: Eric Curtin <[email protected]>
@ericcurtin ericcurtin force-pushed the llamacpp-dep-ramalama branch from 523371b to e39724a Compare April 15, 2025 10:40
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Apr 15, 2025
@ericcurtin
Copy link
Contributor Author

@daeho-ro PTAL

@stefanb stefanb changed the title Add a dependancy on llama.cpp to RamaLama package ramalama: depend on llama.cpp Apr 15, 2025
@daeho-ro
Copy link
Member


install_mac_dependencies() {
  if [ "$EUID" -eq 0 ]; then
    echo "This script is intended to run as non-root on macOS"

    return 1
  fi

  if ! available "brew"; then
    echo "RamaLama requires brew to complete installation."
    echo
    echo "To install brew please run:"
    echo
    echo "curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh | bash"
    echo

    return 2
  fi

  brew install llama.cpp
  echo
}

I found the installation script and so it might be worth to depends on it.

Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Apr 16, 2025
@BrewTestBot BrewTestBot enabled auto-merge April 16, 2025 01:23
@BrewTestBot BrewTestBot added this pull request to the merge queue Apr 16, 2025
Merged via the queue into Homebrew:master with commit 61cbc74 Apr 16, 2025
14 checks passed
@ericcurtin ericcurtin deleted the llamacpp-dep-ramalama branch April 16, 2025 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. python Python use is a significant feature of the PR or issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants