Skip to content

crystal: use 84codes deb to bootstrap arm64 linux #220398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 19, 2025
Merged

Conversation

cho-m
Copy link
Member

@cho-m cho-m commented Apr 17, 2025

84codes images/packages are recommended/used by upstream so I think these are safe to use.

Other options from https://crystal-lang.org/install/ probably won't work (i.e. Alpine and Nix).

@cho-m cho-m added CI-no-bottles Merge without publishing bottles linux-arm-bottling labels Apr 17, 2025
@github-actions github-actions bot added the no ARM bottle Formula has no ARM bottle label Apr 17, 2025
@cho-m cho-m force-pushed the crystal-arm-linux branch from 3777589 to 263979e Compare April 17, 2025 04:18
@cho-m cho-m added maintainer feedback Additional maintainers' opinions may be needed automerge-skip `brew pr-automerge` will skip this pull request labels Apr 17, 2025
@cho-m cho-m marked this pull request as ready for review April 17, 2025 04:21
@fxcoudert
Copy link
Member

Yes, it seems acceptable to me.

Copy link
Member

@branchvincent branchvincent left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree as well

@p-linnane p-linnane removed maintainer feedback Additional maintainers' opinions may be needed automerge-skip `brew pr-automerge` will skip this pull request labels Apr 19, 2025
@p-linnane p-linnane added this pull request to the merge queue Apr 19, 2025
Merged via the queue into master with commit 78b27f8 Apr 19, 2025
33 checks passed
@p-linnane p-linnane deleted the crystal-arm-linux branch April 19, 2025 04:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI-no-bottles Merge without publishing bottles linux-arm-bottling no ARM bottle Formula has no ARM bottle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants