Skip to content

node@20 20.19.1 #220952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

node@20 20.19.1 #220952

wants to merge 1 commit into from

Conversation

BrewTestBot
Copy link
Member

Created by brew bump


Created by brew bump-formula-pr.

@github-actions github-actions bot added legacy Relates to a versioned @ formula formula deprecated Formula deprecated long build Set a long timeout for formula testing icu4c ICU use is a significant feature of the PR or issue labels Apr 22, 2025
@chenrui333
Copy link
Member

In file included from ../deps/v8/third_party/zlib/zutil.c:10:
  In file included from ../deps/v8/third_party/zlib/gzguts.h:21:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/stdio.h:61:
  /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/_stdio.h:318:7: error: expected identifier or '('
    318 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fdopen));
        |          ^
  ../deps/v8/third_party/zlib/zutil.h:162:33: note: expanded from macro 'fdopen'
    162 | #        define fdopen(fd,mode) NULL /* No fdopen() */
        |                                 ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:16: note: expanded from macro 'NULL'
     26 | #define NULL ((void*)0)
        |                ^
  In file included from ../deps/v8/third_party/zlib/zutil.c:10:
  In file included from ../deps/v8/third_party/zlib/gzguts.h:21:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/stdio.h:61:
  /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/_stdio.h:318:7: error: expected ')'
  ../deps/v8/third_party/zlib/zutil.h:162:33: note: expanded from macro 'fdopen'
    162 | #        define fdopen(fd,mode) NULL /* No fdopen() */
        |                                 ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:16: note: expanded from macro 'NULL'
     26 | #define NULL ((void*)0)
        |                ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/_stdio.h:318:7: note: to match this '('
  ../deps/v8/third_party/zlib/zutil.h:162:33: note: expanded from macro 'fdopen'
    162 | #        define fdopen(fd,mode) NULL /* No fdopen() */
        |                                 ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:15: note: expanded from macro 'NULL'
     26 | #define NULL ((void*)0)
        |               ^
  In file included from ../deps/v8/third_party/zlib/zutil.c:10:
  In file included from ../deps/v8/third_party/zlib/gzguts.h:21:
  In file included from /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/stdio.h:61:
  /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/_stdio.h:318:7: error: expected ')'
    318 | FILE    *fdopen(int, const char *) __DARWIN_ALIAS_STARTING(__MAC_10_6, __IPHONE_2_0, __DARWIN_ALIAS(fdopen));
        |          ^
  ../deps/v8/third_party/zlib/zutil.h:162:33: note: expanded from macro 'fdopen'
    162 | #        define fdopen(fd,mode) NULL /* No fdopen() */
        |                                 ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:22: note: expanded from macro 'NULL'
     26 | #define NULL ((void*)0)
        |                      ^
  /Library/Developer/CommandLineTools/SDKs/MacOSX15.sdk/usr/include/_stdio.h:318:7: note: to match this '('
  ../deps/v8/third_party/zlib/zutil.h:162:33: note: expanded from macro 'fdopen'
    162 | #        define fdopen(fd,mode) NULL /* No fdopen() */
        |                                 ^
  /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/lib/clang/17/include/__stddef_null.h:26:14: note: expanded from macro 'NULL'
     26 | #define NULL ((void*)0)
        |              ^
    clang -o /private/tmp/nodeA20-20250422-7[127](https://github.com/Homebrew/homebrew-core/actions/runs/14593257695/job/40933317572?pr=220952#step:3:128)-ccqxzx/node-v20.19.1/out/Release/obj.target/llhttp/deps/llhttp/src/llhttp.o ../deps/llhttp/src/llhttp.c '-D_GLIBCXX_USE_CXX11_ABI=1' '-DNODE_OPENSSL_CONF_NAME=nodejs_conf' '-DNODE_OPENSSL_CERT_STORE' '-DICU_NO_USER_DATA_OVERRIDE' '-D_DARWIN_USE_64_BIT_INODE=1' -I/opt/homebrew/opt/libuv/include -I/opt/homebrew/opt/brotli/include -I/opt/homebrew/opt/c-ares/include -I/opt/homebrew/opt/libnghttp2/include -I/opt/homebrew/opt/openssl@3/include -I/opt/homebrew/Cellar/icu4c@77/77.1/include -I../deps/llhttp -I../deps/llhttp/include  -O3 -gdwarf-2 -flto -mmacosx-version-min=10.15 -arch arm64 -Wall -Wendif-labels -W -Wno-unused-parameter -fno-strict-aliasing -MMD -MF /private/tmp/nodeA20-20250422-7127-ccqxzx/node-v20.19.1/out/Release/.deps//private/tmp/nodeA20-20250422-7127-ccqxzx/node-v20.19.1/out/Release/obj.target/llhttp/deps/llhttp/src/llhttp.o.d.raw   -c
  3 errors generated.

@chenrui333 chenrui333 added the build failure CI fails while building the software label Apr 22, 2025
@Bo98
Copy link
Member

Bo98 commented Apr 22, 2025

Check if https://github.com/Bo98/node/commit/fdc3645a08ca26062ece674615a2425b908ebf30.patch?full_index=1 fixes it and I can submit it upstream.

@daeho-ro
Copy link
Member

daeho-ro commented Apr 23, 2025

zlib again... we have same discussion from here,

node@20: add build patch

Signed-off-by: Rui Chen <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build failure CI fails while building the software formula deprecated Formula deprecated icu4c ICU use is a significant feature of the PR or issue legacy Relates to a versioned @ formula long build Set a long timeout for formula testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants