Skip to content

Conversation

@heeeyflo
Copy link

@heeeyflo heeeyflo commented Jan 3, 2026

Adds a new formula for jedisct1/zig-minisign.

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added new formula PR adds a new formula to Homebrew/homebrew-core zig Zig use is a significant feature of the PR or issue labels Jan 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@heeeyflo heeeyflo force-pushed the add-minizign-formula branch 3 times, most recently from c0fa8ae to ec58380 Compare January 3, 2026 04:58
@heeeyflo heeeyflo force-pushed the add-minizign-formula branch from ec58380 to 6fcc44c Compare January 3, 2026 13:58
@heeeyflo heeeyflo requested a review from daeho-ro January 3, 2026 13:59

test do
# Generate a test key pair with an empty password
IO.popen([bin/"minizign", "-G", "-s", testpath/"test.key", "-p", testpath/"test.pub"], "w") do |io|
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t pipe_output work here?

Copy link
Author

@heeeyflo heeeyflo Jan 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wouldn’t pipe_output work here?

@SMillerDev Good catch, I totally missed it in assertions. Fixed now.

Adds a new formula for jedisct1/zig-minisign.
@heeeyflo heeeyflo force-pushed the add-minizign-formula branch from 6fcc44c to c8ac4a4 Compare January 4, 2026 20:55
@heeeyflo heeeyflo requested a review from SMillerDev January 4, 2026 20:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

new formula PR adds a new formula to Homebrew/homebrew-core zig Zig use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants