-
-
Notifications
You must be signed in to change notification settings - Fork 13.3k
openbao: fix version reporting and simplify build #261053
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
|
Caution Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave. |
1bf2026 to
f393651
Compare
|
Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request. |
|
It seems that you are removing ui part, is it fine? |
|
It did that on purpose, yes. That being said, I am no maintainer or contributor to Openbao in any way, just a normal user. But yes, if the bottles contain the UI and the source build doesn't this should likely at least be noted during formula installation. |
- Add ldflags to set version info (was showing 2.0.0-HEAD) - Remove UI build to match official releases - Remove node/yarn dependencies Refs: openbao/openbao#400
bao --versionreporting incorrect version (2.0.0-HEADinstead of actual version)Problem
The current formula runs
make dev-uiwhich:bao --versionto show2.0.0-HEADDetails
Before:
bao --version OpenBao v2.0.0-HEAD ('4bfd70723d4f9b82be00e87b8c018ac661dd9b99'), built 2025-11-24T14:37:04Z2025-11-24 is the release date of v2.4.4.
After the patch:
Note: Current binaries still reference the wrong version as they were built without the required LDFLAGS.
See also openbao/openbao#401
HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?