Skip to content

Conversation

@pat-s
Copy link

@pat-s pat-s commented Jan 3, 2026

  • Fix bao --version reporting incorrect version (2.0.0-HEAD instead of actual version)
  • Remove UI build (node, yarn dependencies) to match official OpenBao releases
  • Add ldflags to inject version info during Go build

Problem

The current formula runs make dev-ui which:

  1. Doesn't pass ldflags to set version variables, causing bao --version to show 2.0.0-HEAD
  2. Attempts to build the Ember UI which has known build failures and is not included in official OpenBao binaries

Details

Before:

bao --version
OpenBao v2.0.0-HEAD ('4bfd70723d4f9b82be00e87b8c018ac661dd9b99'), built 2025-11-24T14:37:04Z

2025-11-24 is the release date of v2.4.4.

After the patch:

go build -ldflags=-s -w -X github.com/openbao/openbao/version.fullVersion=2.4.4 -X github.com/openbao/openbao/version.GitCommit=4bfd70723d4f9b82be00e87b8c018ac66
==> Caveats
To start pjs/local/openbao now and restart at login:
  brew services start pjs/local/openbao
Or, if you don't want/need a background service you can just run:
  /opt/homebrew/opt/openbao/bin/bao server -dev
==> Summary
🍺  /opt/homebrew/Cellar/openbao/2.4.4: 9 files, 118.4MB, built in 1 minute 20 seconds
==> Running `brew cleanup openbao`...

❯ bao --version
OpenBao v2.4.4 (4bfd70723d4f9b82be00e87b8c018ac661dd9b99), built 2025-11-24T19:37:04Z (cgo)

Note: Current binaries still reference the wrong version as they were built without the required LDFLAGS.

See also openbao/openbao#401

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. go Go use is a significant feature of the PR or issue labels Jan 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Caution

Please do not modify the bottle block. Bottle block modifications can cause CI to misbehave.
@BrewTestBot will handle updating the bottle block before this PR is merged.

@pat-s pat-s force-pushed the patch-1 branch 2 times, most recently from 1bf2026 to f393651 Compare January 3, 2026 12:49
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jan 3, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 3, 2026

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@daeho-ro
Copy link
Member

daeho-ro commented Jan 4, 2026

It seems that you are removing ui part, is it fine?

@pat-s
Copy link
Author

pat-s commented Jan 4, 2026

It did that on purpose, yes.
AFAICS the formula is broken for source builds in its current state. At least it errors on my side (Sequoia) when building from source.
On macOS, in 99.x% only the CLI is desired. Openbao server is hosted and run on Linux, not on macOS.

That being said, I am no maintainer or contributor to Openbao in any way, just a normal user.
I'd mainly be happy to have a proper version output in the binaries. I don't care much about the UI for this formula but I also don't want to debug this part.

But yes, if the bottles contain the UI and the source build doesn't this should likely at least be noted during formula installation.

@github-actions github-actions bot added the nodejs Node or npm use is a significant feature of the PR or issue label Jan 4, 2026
- Add ldflags to set version info (was showing 2.0.0-HEAD)
- Remove UI build to match official releases
- Remove node/yarn dependencies

Refs: openbao/openbao#400
@pat-s pat-s marked this pull request as ready for review January 6, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

go Go use is a significant feature of the PR or issue nodejs Node or npm use is a significant feature of the PR or issue

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants