percona-toolkit: fix missing go tools issue

[svetasmirnova]

• Have you followed the guidelines for contributing?
• Have you ensured that your commits follow the commit style guide?
• Have you checked that there aren't other open pull requests for the same formula update/change?
• Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
• Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
• Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

---

[chenrui333]

can you also add test to verify the change? also can bump the revision as well?

[gromgit]

Homebrew builds for all of {Intel,ARM}-{Linux,macOS}, so this hardcoding is guaranteed to fail on three different build platforms. You should probably do something similar to

homebrew-core/Formula/n/newrelic-infra-agent.rb

Lines 29 to 34 in 7e9261b

	goarch = Hardware::CPU.intel? ? "amd64" : Hardware::CPU.arch.to_s
	os = OS.kernel_name.downcase
	ENV["VERSION"] = version.to_s
	ENV["GOOS"] = os
	ENV["CGO_ENABLED"] = OS.mac? ? "1" : "0"
	ENV["GOARCH"] = goarch

to derive the appropriate os/arch settings.

[cho-m]

Linking my comment at #261450 (comment)

---

The changes here won't work as issue is not GOOS/GOARCH but how MakeMaker expands globs.

To showcase this, you can compare Makefile output of following:

perl Makefile.PL

EXE_FILES = bin/pt-align bin/pt-archiver bin/pt-config-diff bin/pt-deadlock-logger bin/pt-diskstats bin/pt-duplicate-key-checker bin/pt-eustack-resolver bin/pt-fifo-split bin/pt-find bin/pt-fingerprint bin/pt-fk-error-logger bin/pt-heartbeat bin/pt-index-usage bin/pt-ioprofile bin/pt-kill bin/pt-mext bin/pt-mysql-summary bin/pt-online-schema-change bin/pt-pmp bin/pt-query-digest bin/pt-replica-find bin/pt-replica-restart bin/pt-show-grants bin/pt-sift bin/pt-slave-delay bin/pt-slave-find bin/pt-slave-restart bin/pt-stalk bin/pt-summary bin/pt-table-checksum bin/pt-table-sync bin/pt-table-usage bin/pt-upgrade bin/pt-variable-advisor bin/pt-visual-explain

make -C src/go build && perl Makefile.PL

EXE_FILES = bin/pt-align bin/pt-archiver bin/pt-config-diff bin/pt-deadlock-logger bin/pt-diskstats bin/pt-duplicate-key-checker bin/pt-eustack-resolver bin/pt-fifo-split bin/pt-find bin/pt-fingerprint bin/pt-fk-error-logger bin/pt-galera-log-explainer bin/pt-heartbeat bin/pt-index-usage bin/pt-ioprofile bin/pt-k8s-debug-collector bin/pt-kill bin/pt-mext bin/pt-mongodb-index-check bin/pt-mongodb-query-digest bin/pt-mongodb-summary bin/pt-mysql-summary bin/pt-online-schema-change bin/pt-pg-summary bin/pt-pmp bin/pt-query-digest bin/pt-replica-find bin/pt-replica-restart bin/pt-secure-collect bin/pt-show-grants bin/pt-sift bin/pt-slave-delay bin/pt-slave-find bin/pt-slave-restart bin/pt-stalk bin/pt-summary bin/pt-table-checksum bin/pt-table-sync bin/pt-table-usage bin/pt-upgrade bin/pt-variable-advisor bin/pt-visual-explain