llama.cpp: build the unified llama binary#284022
Open
julien-c wants to merge 1 commit into
Open
Conversation
17ad693 to
a288c1f
Compare
Contributor
Author
|
@carlocab @cho-m i am proposing for your consideration that we opt-in to building the new cc @botantony for your thoughts too Thanks! |
carlocab
reviewed
May 21, 2026
| -DBUILD_SHARED_LIBS=ON | ||
| -DCMAKE_INSTALL_RPATH=#{rpath} | ||
| -DLLAMA_ALL_WARNINGS=OFF | ||
| -DLLAMA_BUILD_APP=ON |
Member
There was a problem hiding this comment.
Does upstream use this configuration in the binaries they build?
Contributor
Author
There was a problem hiding this comment.
good question, let's see where ggml-org/llama.cpp#23488 lands maybe
Contributor
Author
There was a problem hiding this comment.
Member
There was a problem hiding this comment.
I see it's on by default, but that's not even in a release yet. Let's wait for it to bake a bit before turning it on here. It'll likely be enabled on the next autobump PR anyway.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enable
-DLLAMA_BUILD_APP=ONto install the unifiedllamabinary introduced in ggml-org/llama.cpp#23296. The new binary dispatches toserve/clisubcommands; existingllama-completion,llama-server, etc. continue to be installed alongside.Tag is bumped to
b9265becauseb9260predates #23296.Smoke test verifies the new binary is on
PATHand prints its command list (it exits 1 when invoked with no args).HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>?brew test <formula>?brew audit --strict <formula>(after doingHOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it passbrew audit --new <formula>?Claude Code drafted the formula diff (cmake flag, tag bump, smoke test) under my direction. I verified that
-DLLAMA_BUILD_APP=ONproduces a workingbuild/bin/llamaby building llama.cpp@b9265 locally with the same flag outside the formula; I have not yet runbrew install --build-from-source llama.cppagainst the formula itself.brew styleandbrew audit(non-strict) pass.